Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with rgbinit unused variable #3165

Merged
merged 2 commits into from
Jun 13, 2018
Merged

fix issue with rgbinit unused variable #3165

merged 2 commits into from
Jun 13, 2018

Conversation

ylixir
Copy link
Contributor

@ylixir ylixir commented Jun 11, 2018

No description provided.

@drashna
Copy link
Member

drashna commented Jun 11, 2018

#3113 Is probably a much better way to handle this.

There are some other issues with using matrix_init, actually, and having "keyboard init" that runs later fixes those too.

Also, I think you mean rgblight_init is never defined here, so this code would never get called, and is causing travis CI to fail.
Also... this would prevent rgblight_init(); from resetting the settings, after the board is on.

@ylixir
Copy link
Contributor Author

ylixir commented Jun 11, 2018

@drashna oh I fail. I had made the change on a different branch and apparently was too lazy to even compile it. I had intended to check if rgblight_inited had been set.

Anyway, your PR is better. I hadn't considered the need to reinitialize a running board.

But since rgblight_inited isn't actually being used without my proposed changes, I've re-purposed this PR to remove the dead code.

@ylixir ylixir changed the title fix issue with rgbinit wiping out customization. fix issue with rgbinit unused variable Jun 11, 2018
@drashna
Copy link
Member

drashna commented Jun 12, 2018

@jackhumbert any issue with removing this variable?

It doesn't seem to be used anywhere else, from what I can tell.

@jackhumbert
Copy link
Member

I suppose that's fine!

@drashna
Copy link
Member

drashna commented Jun 13, 2018

Just wanted to make sure first. :)

@drashna drashna merged commit 974d155 into qmk:master Jun 13, 2018
noj added a commit to noj/qmk_firmware that referenced this pull request Jun 16, 2018
@noj
Merge branch 'master' of https://github.com/qmk/qmk_firmware into noj…
8388f10 
…jan_atreus

* 'master' of https://github.com/qmk/qmk_firmware: (578 commits)
  Contra refactor (qmk#3191)
  Fixed no-op ifndef for ergodox ez (qmk#3189)
  Canoe Refactor (qmk#3190)
  planck/light/info.json fix (qmk#3186)
  Tada68 refactor and readme update (qmk#3178)
  Add URL of PCB files to README.md (qmk#3182)
  Rename from KEYMAP to LAYOUT (qmk#3181)
  Fix bfake matrix bug (qmk#3180)
  Clueboard 2x1800 Refactor (qmk#3179)
  QMK Configurator Support for Melody96 (qmk#3177)
  Lightsaver info.json update (qmk#3176)
  KBD66 info.json update (qmk#3175)
  Mbsurfer deltasplit75 keymap (qmk#3174)
  Configurator layout repair for Ergodone, Ergodox Infinity and ErgoTravel (qmk#3173)
  Ergodox EZ refactor (qmk#3171)
  Hadron: Readme, Refactor, and Configurator support (qmk#3170)
  fix issue with rgbinit unused variable (qmk#3165)
  Fix melody96 default keymap graphic. (qmk#3169)
  Fix jj40 capslock and minor keymap updates (qmk#3168)
  GON NerD: Refactor, Configurator support and Readme cleanup (qmk#3167)
  ...
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@ylixir @yamad
fix issue with rgbinit unused variable (qmk#3165)
4393e41 
* fix issue with rgbinit wiping out customization.

* removed unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ylixir @drashna @jackhumbert