Better non-Linux support #2524
Merged
Better non-Linux support #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UNIXy systems (FreeBSD for example) don't use GNU grep by default. Allow the user to specify which grep implementation to use so that GNU grep can be specified.
Don't hardcode "avr-gcc", and allow strings such as "avr-gcc8", or "avr-gcc-7.3.0" to match checks for "avr-gcc".
|
Nice! I'm not super familiar with how grep is accessed - do all systems define GREP properly? |
|
It's actually weakly set to "grep" in the avr.mk makefile. It's not set by default on any platform, so it just uses "grep" unless a user runs "make GREP=gnugrep" or similar. A future change could be to decide how to set GREP based on platform. |
|
Ah, right! Perfect - thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow a user to select which version of grep and avr-gcc to use. This is useful because FreeBSD and OpenBSD don't necessarily use GNU grep, and sometimes a developer might install a non-default version of avr-gcc.