Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor opendeck/32 #24233

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Refactor opendeck/32 #24233

merged 1 commit into from
Aug 3, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 3, 2024

Description

Main aim was to remove process_record_kb logic, but figured it was worth updating while changing files.

  • Disabling rgb keycodes while having all effects enabled is somewhat pointless
  • Aligned default enabled features to general recommended
  • Removed suspend_power_down_user/suspend_wakeup_init_user duplicating core behaviour
  • RGB Matrix defaults to on, so post_init is pointless
  • Removed "size optimisations" as the firmware is comfortably undersized without

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Aug 3, 2024
@zvecr zvecr merged commit 8808fff into develop Aug 3, 2024
3 checks passed
@zvecr zvecr deleted the refactor_opendeck branch August 3, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants