Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous keyboard.json migrations #23378

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 30, 2024

Description

Problematic keyboards which cannot be automatically migrated. These have been discovered by the following...

for kb in $(qmk list-keyboards); do
    if [[ -f keyboards/${kb}/info.json && -f keyboards/${kb}/rules.mk ]]; then
        true
    elif [[ ! -f keyboards/${kb}/keyboard.json ]]; then
        echo $kb
    fi
done

Common issue seems to be a far less than ideal folder structure, where code is split between a subrevision.

Where specified, DEFAULT_FOLDER has been kept, but now as the only line in a rules.mk.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the migrate_keyboard_json_misc branch 2 times, most recently from 4220309 to 4bb2fb9 Compare March 30, 2024 18:21
@zvecr zvecr force-pushed the migrate_keyboard_json_misc branch from 4bb2fb9 to 0ede486 Compare March 31, 2024 20:02
@zvecr zvecr force-pushed the migrate_keyboard_json_misc branch from 0ede486 to 2c02a88 Compare April 2, 2024 16:53
@zvecr zvecr merged commit f29daff into develop Apr 3, 2024
2 of 3 checks passed
@zvecr zvecr deleted the migrate_keyboard_json_misc branch April 3, 2024 22:14
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants