Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove completely redundant DEFAULT_FOLDER from keyboards #23377

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Remove completely redundant DEFAULT_FOLDER from keyboards #23377

merged 1 commit into from
Mar 31, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 30, 2024 •
edited
Loading

Description

DEFAULT_FOLDER pointing to the same location is 100% completely pointless.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team March 30, 2024 15:48
@zvecr zvecr merged commit 5db6f79 into develop Mar 31, 2024
2 of 3 checks passed
@zvecr zvecr deleted the pointless_default_folder branch March 31, 2024 07:49
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Remove redundant DEFAULT_FOLDER from keyboards (qmk#23377)
4e77cc0
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Remove redundant DEFAULT_FOLDER from keyboards (qmk#23377)
da3fae0
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Remove redundant DEFAULT_FOLDER from keyboards (qmk#23377)
65decf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@dunk2k dunk2k dunk2k approved these changes

@lesshonor lesshonor lesshonor approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @waffle87 @dunk2k @lesshonor