Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build target markers to keyboard.json #23293

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 15, 2024

Description

(Empty rules.mk) | (rules.mk with just comments) -> keyboard.json

Script used

for kb in $(qmk list-keyboards); do
    if [ -f keyboards/${kb}/info.json ]; then
        # ignrore blank lines and those starting with comments
        lines=$(cat keyboards/${kb}/rules.mk | grep . | grep -Ev "^#.*" | wc -l)
        if [[ $lines == 0 ]]; then
            git mv keyboards/${kb}/info.json keyboards/${kb}/keyboard.json
            git rm keyboards/${kb}/rules.mk
        fi
    fi
done

Only ~1300 keyboards still to migrate... 😢

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 831deac into develop Mar 30, 2024
1 of 3 checks passed
@zvecr zvecr deleted the migrate_rules_mk9 branch March 30, 2024 11:31
@dunk2k dunk2k mentioned this pull request Jun 1, 2024
14 tasks
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants