Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds rot13labs hackboard #23218

Merged
merged 19 commits into from
Mar 30, 2024
Merged

adds rot13labs hackboard #23218

merged 19 commits into from
Mar 30, 2024

Conversation

c0ldbru
Copy link
Contributor

@c0ldbru c0ldbru commented Mar 4, 2024

Description

Adds rot13labs hackboard as a new keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/rot13labs/hackboard/info.json Show resolved Hide resolved
keyboards/rot13labs/hackboard/rules.mk Outdated Show resolved Hide resolved
c0ldbru and others added 5 commits March 6, 2024 12:04
removing enables from rules to move into info.json features
adds features from rules.mk
removes community layout as the hackboard does not support the tkl_ansi community layout
@c0ldbru c0ldbru requested a review from dunk2k March 7, 2024 14:19
@dunk2k
Copy link
Contributor

dunk2k commented Mar 7, 2024

it appears layout information in info.json and readme.md image don't match. When compared, the info.json matrix has an additional key on top row - is this intended?
capture

@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 7, 2024

@dunk2k yeah, the button itself is very unique and im basically just hijacking an open spot in the grid so the button can be programmed via QMK as if it was a switch. I designed the hardware before I fully understood QMK so its not ideal, but it still works very well for my needs.

TL:DR; functionally the layout you posted is correct, even though visually the keyboard appears to match the standard community layout.

@dunk2k
Copy link
Contributor

dunk2k commented Mar 7, 2024

Thanks for explaining, it's that extra button is what was putting the community layout awry. Would the unique button be better placed a row, of sorts, above the Function row?

@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 7, 2024

Oh, yeah as long as its just for visuals sake I think that would be great! How/where can I do that so it wont affect the functionality?

@dunk2k
Copy link
Contributor

dunk2k commented Mar 8, 2024

  1. info.json:+1 to all "y" co-ordinates in layouts, and move the unique key to "y": 0. Would it be correct to assume, from the readme.md image, that the unique button has a red LED and his positioned top left of the micro controller on PCB?
  2. <keymap_dir>/keymap.c: move the unique button's keycode position in sequence from 2nd to 1st. Could even place it on its own row to match layouts in info.json.

Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conforms to PR Checklist regarding physical layout(s)

keyboards/rot13labs/hackboard/info.json Outdated Show resolved Hide resolved
keyboards/rot13labs/hackboard/keymaps/default/keymap.c Outdated Show resolved Hide resolved
c0ldbru and others added 4 commits March 9, 2024 11:33
updates the layout to more closely match the hackboard
updates the keymap to match the new layout
@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 9, 2024

  1. info.json:+1 to all "y" co-ordinates in layouts, and move the unique key to "y": 0. Would it be correct to assume, from the readme.md image, that the unique button has a red LED and his positioned top left of the micro controller on PCB?
  2. <keymap_dir>/keymap.c: move the unique button's keycode position in sequence from 2nd to 1st. Could even place it on its own row to match layouts in info.json.

Sweet! Thanks! Thats been updated now.

@c0ldbru c0ldbru requested a review from dunk2k March 10, 2024 14:55
@dunk2k
Copy link
Contributor

dunk2k commented Mar 10, 2024

@c0ldbru
To follow up on an earlier question: does the unique button, now on top row, have a red LED and his positioned top left of the micro controller on PCB?

@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 10, 2024

nah, its to the left of the boot and reset buttons; above F4/F5

@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 12, 2024

@dunk2k Just checking in to make sure theres nothing waiting on me for this? Let me know if theres anything I missed!

keyboards/rot13labs/hackboard/info.json Outdated Show resolved Hide resolved
keyboards/rot13labs/hackboard/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rot13labs/hackboard/info.json Outdated Show resolved Hide resolved
@c0ldbru c0ldbru requested a review from dunk2k March 13, 2024 05:11
@c0ldbru c0ldbru requested a review from drashna March 21, 2024 12:56
@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 24, 2024

@drashna Any chance you can review this? I believe your approval is all its waiting on.

@c0ldbru
Copy link
Contributor Author

c0ldbru commented Mar 28, 2024

@dunk2k is it possible to merge this with just your approval? @drashna seems to have disappeared from this PR but I still would like to get this added for people out there using the hackboard.

@dunk2k
Copy link
Contributor

dunk2k commented Mar 28, 2024

@dunk2k is it possible to merge this with just your approval? @drashna seems to have disappeared from this PR but I still would like to get this added for people out there using the hackboard.

@c0ldbru, unfortunately I'm not a QMK maintainer, thus I'm unable to merge PRs. Could I suggest on the qmk_firmware channel of the QMK Discord, relay this PR's number and ask if it could be given a look over 🙂

@drashna drashna requested a review from a team March 28, 2024 23:08
@waffle87 waffle87 merged commit 72ec742 into qmk:master Mar 30, 2024
3 checks passed
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
Co-authored-by: c0ldbru <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
Co-authored-by: c0ldbru <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Co-authored-by: c0ldbru <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants