post- zvecr review fixes & move vendor keymap to vendor sub-folder

qmk · zvecr · Jan 31, 2024 · Dec 5, 2023 · Dec 16, 2023 · Jan 3, 2024
commit 388b4e0f1b95ff8380ef5c923727baee6ff77223
diff --git a/keyboards/binepad/bnk9/config.h b/keyboards/binepad/bnk9/config.h
@@ -7,16 +7,7 @@
 
 #ifdef RGB_MATRIX_ENABLE
  #define WS2812_PIO_USE_PIO1
- // #define RGB_MATRIX_TIMEOUT 600000 // 10 minutes
- #define RGB_DISABLE_WITH_FADE_OUTS
- #define RGB_DISABLE_WHEN_USB_SUSPENDED
- #define RGB_MATRIX_LED_PROCESS_LIMIT 9 // All nine keys
- #define RGB_MATRIX_MAXIMUM_BRIGHTNESS 180 // Not too bright so that the LED's don't burn out
 
  // Timing for SK6812
- #define WS2812_TIMING 1250
- #define WS2812_T0H 350
- #define WS2812_T0L (WS2812_TIMING - WS2812_T0H)
- #define WS2812_T1H 650
- #define WS2812_T1L (WS2812_TIMING - WS2812_T1H)
+ #define WS2812_T1H 650
 #endif
diff --git a/keyboards/binepad/bnk9/info.json b/keyboards/binepad/bnk9/info.json
@@ -43,6 +43,9 @@
  },
  "rgb_matrix": {
  "driver": "ws2812",
+ "led_process_limit": 9,
+ "max_brightness": 180,
+ "sleep": true,
  "animations": {
  "solid_color": true,
  "breathing": true,

diff --git a/keyboards/binepad/bnk9/bnk9.h → ...oards/binepad/bnk9/keymaps/binepad/bnk9.h b/keyboards/binepad/bnk9/bnk9.h → ...oards/binepad/bnk9/keymaps/binepad/bnk9.h
diff --git a/keyboards/binepad/bnk9/bnk9_effect.c → ...inepad/bnk9/keymaps/binepad/bnk9_effect.c b/keyboards/binepad/bnk9/bnk9_effect.c → ...inepad/bnk9/keymaps/binepad/bnk9_effect.c
diff --git a/keyboards/binepad/bnk9/keymaps/binepad/keymap.c b/keyboards/binepad/bnk9/keymaps/binepad/keymap.c
@@ -0,0 +1,28 @@
+// Copyright 2023 Binepad (@binpad)
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#include QMK_KEYBOARD_H
+
+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
+ [0] = LAYOUT(
+ KC_MUTE,
+ KC_P1, KC_P2, KC_P3,
+ KC_P4, KC_P5, KC_P6,
+ KC_P7, KC_P8, LT(1, KC_P9)
+ ),
+ [1] = LAYOUT(
+ RGB_TOG,
+ RGB_HUI, RGB_SAI, RGB_SPI,
+ RGB_HUD, RGB_SAD, RGB_SPD,
+ RGB_RMOD, RGB_MOD, _______
+ )
+};
+
+#if defined(ENCODER_MAP_ENABLE)
+
+const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS] = {
+ [0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) },
+ [1] = { ENCODER_CCW_CW(RGB_VAD, RGB_VAI) }
+};
+
+#endif
diff --git a/keyboards/binepad/bnk9/rgb_matrix_kb.inc → ...ad/bnk9/keymaps/binepad/rgb_matrix_kb.inc b/keyboards/binepad/bnk9/rgb_matrix_kb.inc → ...ad/bnk9/keymaps/binepad/rgb_matrix_kb.inc
diff --git a/keyboards/binepad/bnk9/keymaps/binepad/rules.mk b/keyboards/binepad/bnk9/keymaps/binepad/rules.mk
@@ -0,0 +1,5 @@
+VIA_ENABLE = yes
+ENCODER_MAP_ENABLE = yes
+
+RGB_MATRIX_CUSTOM_KB = yes
+SRC += bnk9_effect.c
diff --git a/keyboards/binepad/bnk9/keymaps/default/rules.mk b/keyboards/binepad/bnk9/keymaps/default/rules.mk
@@ -0,0 +1 @@
+ENCODER_MAP_ENABLE = yes
diff --git a/keyboards/binepad/bnk9/keymaps/via/rules.mk b/keyboards/binepad/bnk9/keymaps/via/rules.mk
@@ -1,3 +1,2 @@
-# @see `info.json` for config
-
 VIA_ENABLE = yes
+ENCODER_MAP_ENABLE = yes
diff --git a/keyboards/binepad/bnk9/rules.mk b/keyboards/binepad/bnk9/rules.mk
@@ -1,4 +1 @@
-# @see `info.json` for config
-
-RGB_MATRIX_CUSTOM_KB = yes
-SRC += bnk9_effect.c
+# This file intentionally left blank