fix: improper usage of keyboard/user-level functions #22652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct several instances of keyboard-level code incorrectly calling (or neglecting to call) user-level functions.
dumbpad/v1x_oled
andrura66/rev1
calloled_task_user()
for keyboard-level code.dumbpad/v1x_oled
andlime/rev1
callencoder_update_user()
for keyboard-level code.aeboards/ext65/rev2
,mino_plus/*
andhorrortroll/lemon40
use the correctoled_task_kb()
, but are missing theif (!oled_task_user())
clause allowing user overrides.Since I was already modifying the file:
aeboards/ext65/rev2
callskeyboard_pre_init_user()
only, instead of callingkeyboard_pre_init_user()
at the end ofkeyboard_pre_init_kb()
.The diff looks more extensive than this because I ran
qmk format-c
on all affected files before making changes. I'm leaving the commits unsquashed so that's easier to see.Types of Changes
Checklist