Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improper usage of keyboard/user-level functions #22652

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

lesshonor
Copy link
Contributor

Description

Correct several instances of keyboard-level code incorrectly calling (or neglecting to call) user-level functions.

  • dumbpad/v1x_oled and rura66/rev1 call oled_task_user() for keyboard-level code.

  • dumbpad/v1x_oled and lime/rev1 call encoder_update_user() for keyboard-level code.

  • aeboards/ext65/rev2, mino_plus/* and horrortroll/lemon40 use the correct oled_task_kb(), but are missing the if (!oled_task_user()) clause allowing user overrides.

  • Since I was already modifying the file: aeboards/ext65/rev2 calls keyboard_pre_init_user() only, instead of calling keyboard_pre_init_user() at the end of keyboard_pre_init_kb().

The diff looks more extensive than this because I ran qmk format-c on all affected files before making changes. I'm leaving the commits unsquashed so that's easier to see.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team December 13, 2023 17:24
@zvecr zvecr merged commit 49527af into qmk:develop Dec 13, 2023
2 of 3 checks passed
@lesshonor lesshonor deleted the fix/overrides branch December 13, 2023 18:34
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants