Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED/RGB Matrix: prefix driver defines #22088

Merged
merged 2 commits into from
Sep 21, 2023
Merged

LED/RGB Matrix: prefix driver defines #22088

merged 2 commits into from
Sep 21, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 20, 2023 •
edited
Loading

Description

For consistency, the idea being to do this for all features with driver selection: FEATURENAME_DRIVERNAME.

Removed STM32_I2C defines as well since they don't seem to be referenced anywhere?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 20, 2023 11:35
@fauxpark fauxpark mentioned this pull request Sep 20, 2023
Merged
14 tasks
@fauxpark fauxpark merged commit db68a95 into qmk:develop Sep 21, 2023
4 checks passed
@fauxpark fauxpark deleted the led-rgb-matrix-driver-defines branch September 21, 2023 02:16
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@fauxpark @mechlovin
LED/RGB Matrix: prefix driver defines (qmk#22088)
5b86c86
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@fauxpark @christrotter
LED/RGB Matrix: prefix driver defines (qmk#22088)
4a9101a
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@fauxpark @zgagnon
LED/RGB Matrix: prefix driver defines (qmk#22088)
cfbd154
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@fauxpark
LED/RGB Matrix: prefix driver defines (qmk#22088)
a6e7547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fauxpark @zvecr