Remove custom ISSI lighting code #22073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Sep 23, 2023
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
* Remove CU75 custom lighting * Remove LFK78 custom lighting * Remove LFK87 custom lighting * Remove LFKPad custom lighting * Remove Mini1800 custom lighting * Remove SMK65 custom lighting * Remove LFK65-HS custom lighting * Remove LFKeyboards custom lighting * Remove Meira custom lighting
christrotter
pushed a commit
to christrotter/qmk_firmware
that referenced
this pull request
Nov 28, 2023
* Remove CU75 custom lighting * Remove LFK78 custom lighting * Remove LFK87 custom lighting * Remove LFKPad custom lighting * Remove Mini1800 custom lighting * Remove SMK65 custom lighting * Remove LFK65-HS custom lighting * Remove LFKeyboards custom lighting * Remove Meira custom lighting
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
* Remove CU75 custom lighting * Remove LFK78 custom lighting * Remove LFK87 custom lighting * Remove LFKPad custom lighting * Remove Mini1800 custom lighting * Remove SMK65 custom lighting * Remove LFK65-HS custom lighting * Remove LFKeyboards custom lighting * Remove Meira custom lighting
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
* Remove CU75 custom lighting * Remove LFK78 custom lighting * Remove LFK87 custom lighting * Remove LFKPad custom lighting * Remove Mini1800 custom lighting * Remove SMK65 custom lighting * Remove LFK65-HS custom lighting * Remove LFKeyboards custom lighting * Remove Meira custom lighting
|
Was this made because the implementations were incompatible or something? Because for at least one of the boards (LFKpad), the lighting code still works perfectly fine even today. This change is seems like it does nothing but remove an existing feature with no apparent benefit? |
|
The benefit is that the QMK maintainers have less of a maintenance burden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These boards are effectively abandonware, and no longer being sold. If someone has one and wants to reimplement RGB/LED Matrix using the core ISSI drivers, they are free to do so.
Types of Changes
Issues Fixed or Closed by This PR
Checklist