Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is0gr to QMK #22024

Merged
merged 9 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add is0gr to QMK
  • Loading branch information
awkannan committed Sep 20, 2023
commit bc9508098ef84b5b4650e58796adf8d7f5ed1512
31 changes: 31 additions & 0 deletions keyboards/cannonkeys/is0gr/info.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"manufacturer": "CannonKeys",
"keyboard_name": "is0GR",
"maintainer": "awkannan",
"processor": "STM32F072",
"bootloader": "stm32-dfu",
"usb": {
"vid": "0x6369",
"pid": "0x6B7B",
"device_version": "0.0.1"
},
"features": {
"bootmagic": true,
"command": false,
"console": false,
"extrakey": true,
"mousekey": true,
"nkro": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command and console are disabled by default and...is nkro truly necessary? 😂

Suggested change
"command": false,
"console": false,
"extrakey": true,
"mousekey": true,
"nkro": true
"extrakey": true,
"mousekey": true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if it's still applicable, but enabling nkro historically improved the output speed of send_string.

Copy link
Contributor Author

@awkannan awkannan Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna keep nkro.
About command and console - sure they are disabled by default, and I have no problem removing them (i have removed them now), but is it really an issue to keep them in as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a collaborator so it's not my call—but IMO: no, which is why I dropped an "approve"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't matter either way, it's just a bit cleaner.

},
"diode_direction": "COL2ROW",
"matrix_pins": {
"rows": ["A15"],
"cols": ["B3"]
},
"url": "https://cannonkeys.com",
"layouts": {
"LAYOUT": {
"layout": [{"matrix": [0,0], "x":0.25, "y":0, "w":1.25, "h":2}]
}
}
}
27 changes: 27 additions & 0 deletions keyboards/cannonkeys/is0gr/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
Copyright 2012,2013 Jun Wako <[email protected]>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http:https://www.gnu.org/licenses/>.
*/
#include QMK_KEYBOARD_H

enum custom_keycodes {
QWERTY = SAFE_RANGE,
};

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[0] = LAYOUT(
KC_ENT
),
};
29 changes: 29 additions & 0 deletions keyboards/cannonkeys/is0gr/keymaps/via/keymap.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/*
Copyright 2012,2013 Jun Wako <[email protected]>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http:https://www.gnu.org/licenses/>.
*/
#include QMK_KEYBOARD_H


enum custom_keycodes {
QWERTY = SAFE_RANGE,
};

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[0] = LAYOUT(
KC_ENT
),
};

1 change: 1 addition & 0 deletions keyboards/cannonkeys/is0gr/keymaps/via/rules.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VIA_ENABLE = yes
25 changes: 25 additions & 0 deletions keyboards/cannonkeys/is0gr/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Alchemist Keyboards is0GR

is0GR Keyboard

Keyboard Maintainer: [Andrew Kannan](https://github.com/awkannan)
Hardware Supported: STM32F072CBT6 or equivalent

Make example for this keyboard (after setting up your build environment):

make cannonkeys/is0gr:default

awkannan marked this conversation as resolved.
Show resolved Hide resolved

Flashing example for this keyboard:

make cannonkeys/is0gr:default:flash

See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).

## Bootloader

Enter the bootloader in 3 ways:

* **Bootmagic reset**: Hold down the key at (0,0) in the matrix (on this board - it's the only key) and plug in the keyboard
* **Physical reset button**: Bridge the two pads labeled "RESET" on the top of the PCB using some tweezers, and hold the tweezers there until the board enters the bootloader mode
* **Keycode in layout**: Press the key mapped to `QK_BOOT` if it is available (it isn't by default)
2 changes: 2 additions & 0 deletions keyboards/cannonkeys/is0gr/rules.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Wildcard to allow APM32 MCU
DFU_SUFFIX_ARGS = -v FFFF -p FFFF