Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mousekey.h include to quantum.h #21897

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Add mousekey.h include to quantum.h #21897

merged 1 commit into from
Sep 4, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 4, 2023

Description

mousekey.h should be implicitly available to keymap code through quantum.h if it is enabled. See #19801 (review)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 4, 2023 00:46
@fauxpark fauxpark mentioned this pull request Sep 4, 2023
Open
14 tasks
@zvecr zvecr merged commit aec7f29 into qmk:develop Sep 4, 2023
3 of 5 checks passed
@fauxpark fauxpark deleted the mousekey-quantum-include branch September 4, 2023 03:01
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@fauxpark @mechlovin
Add mousekey.h include to quantum.h (qmk#21897)
5ea6d26
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@fauxpark @zgagnon
Add mousekey.h include to quantum.h (qmk#21897)
69029ed
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@fauxpark
Add mousekey.h include to quantum.h (qmk#21897)
c119365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug core keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr