Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tap-hold configuration #21383

Merged
merged 1 commit into from
Jul 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions keyboards/lily58/keymaps/gaston/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@

#define QUICK_TAP_TERM 0
#define TAPPING_TERM 150 /* ms */
#define HOLD_ON_OTHER_KEY_PRESS_PER_KEY
11 changes: 11 additions & 0 deletions keyboards/lily58/keymaps/gaston/keymap.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,14 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
)

};

bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record) {
switch (keycode) {
case MT_CESC:
// Immediately select the hold action when another key is pressed.
return true;
default:
// Do not select the hold action when another key is pressed.
return false;
}
}