Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup dekunukem/duckypad #21298

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fixup dekunukem/duckypad #21298

merged 2 commits into from
Jun 19, 2023

Conversation

waffle87
Copy link
Member

Description

  • Move things to data-driven (RGB Matrix, features, etc.)
  • Keyboard level OLED functionality
  • Misc cleanup

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team June 19, 2023 07:13
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 19, 2023
@zvecr zvecr merged commit 74fbd5a into qmk:develop Jun 19, 2023
3 checks passed
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request Jun 19, 2023
@freznel10
Squashed commit of the following:
134d56d 
commit 74fbd5a
Author: jack <[email protected]>
Date:   Mon Jun 19 06:10:25 2023 -0600

    Fixup `dekunukem/duckypad` (qmk#21298)
@waffle87 waffle87 deleted the fix/duckypad branch June 19, 2023 15:16
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request Jun 22, 2023
@freznel10
Squashed commit of the following:
8d99b6b 
commit 5a4fab0
Merge: c601b1f cc4ac72
Author: QMK Bot <[email protected]>
Date:   Thu Jun 22 04:36:15 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit cc4ac72
Author: James Young <[email protected]>
Date:   Wed Jun 21 21:35:35 2023 -0700

    Igloo Configurator Touch-Up (qmk#21303)

    * [refactor] friendly-format info.json

    * [enhancement] add matrix diagram

    * [enhancement] remove key overlaps in layout data

commit c601b1f
Merge: adc954f 33f76d7
Author: QMK Bot <[email protected]>
Date:   Thu Jun 22 02:12:05 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 33f76d7
Author: James Young <[email protected]>
Date:   Wed Jun 21 19:11:32 2023 -0700

    Quarkeys Z40 Community Layout Support and Touch-Up (qmk#21329)

    * [refactor] rename LAYOUT to LAYOUT_planck_mit

    * [style] friendly-format info.json

    * [style] refactor keymaps

    - grid-align keycodes
    - use four-space indent
    - remove trailing whitespace

    * [chore] tidy-up keyboard data in info.json

    - spell-check `manufacturer` value
    - use valid `url`
    - reference GitHub username for `maintainer`

    * [chore] tidy-up readme

    - link to maintainer's GitHub account
    - add Hardware Availability link
    - break-out Hardware Specs into its own section

    * [enhancement] enable Community Layout support

    * [chore] replace product image in readme

    Source repository for previous URL seems to have been deleted.

commit adc954f
Merge: 87b371c b8a12db
Author: QMK Bot <[email protected]>
Date:   Thu Jun 22 00:43:08 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit b8a12db
Author: James Young <[email protected]>
Date:   Wed Jun 21 17:42:30 2023 -0700

    Pteropus: correct layout data (qmk#21326)

    * [style] friendly-format info.json

    * [chore] correct layout data

    Fix keys overlapping when rendered in QMK Configurator or CLI.

commit 87b371c
Author: James Young <[email protected]>
Date:   Wed Jun 21 14:20:02 2023 -0700

    ProtoTypist PT-80 Refactor (qmk#21325)

    * [style] friendly-format info.json

    * [docs] add layout/matrix diagram

    * [style] refactor via keymap

    - grid-align keycodes
    - remove trailing whitespace

    * [refactor] LAYOUT_all macro

    Move the JSON object for the Enter key to the end of the home row.

    * [style] refactor default keymap

    - update keycode grid alignment
    - remove trailing whitespace

    * [refactor] LAYOUT_tkl_iso macro

    Move the JSON object for the Enter key to the end of the home row.

    This commit fixes a key sequence error with the `tkl_iso` Community
    Layout support.

    * [style] refactor default_ansi keymap

    - update keycode grid alignment
    - remove trailing whitespace

    * [bugfix] fix function row matrix assignments for LAYOUT_tkl_iso

    Fix incorrect matrix position assignments on the function row keys for
    the `LAYOUT_tkl_iso` macro.

    * [bugfix] fix function row matrix assignments for LAYOUT_tkl_ansi

    Fix incorrect matrix position assignments on the function row keys for
    the `LAYOUT_tkl_ansi` macro.

commit 810cd9b
Merge: e3faa76 6f39205
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 19:30:39 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 6f39205
Author: James Young <[email protected]>
Date:   Wed Jun 21 12:30:04 2023 -0700

    Laneware LW75: correct layout data (qmk#21314)

    [refactor]

    Fixes misleading Configurator implementations of the available layouts.

commit e3faa76
Merge: fa1b533 20c0043
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 18:42:56 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 20c0043
Author: lindgrenj6 <[email protected]>
Date:   Wed Jun 21 13:42:23 2023 -0500

    [Keymap] Add lindgrenj6 planck layout (qmk#21155)

commit fa1b533
Merge: b6c76cd 4cc427c
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 18:30:50 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 4cc427c
Author: James Young <[email protected]>
Date:   Wed Jun 21 11:30:15 2023 -0700

    Lucid Velvet Solder Layout Additions and Touch-Up (qmk#21313)

    * [refactor] refactor via keymap

    - grid-align keycodes
    - remove trailing whitespace

    * [refactor] refactor default keymap

    - grid-align keycodes
    - remove trailing whitespace

    * [bugfix] fix key sequence error in default keymap

    * [enhancement] fix key overlaps in Configurator

    * [enhancement] add matrix diagram

    * [refactor] rename LAYOUT to LAYOUT_all

    * [enhancement] add LAYOUT_tkl_f13_ansi_split_space_split_bs_rshift

    * [enhancement] add LAYOUT_tkl_f13_ansi_split_bs_rshift

    * [enhancement] add LAYOUT_tkl_f13_ansi

    * [enhancement] add LAYOUT_tkl_f13_iso_split_space_split_bs_rshift

    * [enhancement] add LAYOUT_tkl_f13_iso_split_bs_rshift

    * [enhancement] add LAYOUT_tkl_f13_iso

commit b6c76cd
Merge: 673b536 b814ff5
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 17:39:03 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit b814ff5
Author: James Young <[email protected]>
Date:   Wed Jun 21 10:38:18 2023 -0700

    Lucid Velvet Hotswap Layout Additions and Touch-Up (qmk#21312)

    * [refactor] refactor via keymap

    - grid-align keycodes
    - remove trailing whitespace

    * [refactor] refactor default keymap

    - grid-align keycodes
    - remove trailing whitespace

    * [bugfix] fix key sequence error in default keymap

    * [enhancement] fix key overlap in Configurator

    * [enhancement] add matrix diagram

    * [refactor] rename LAYOUT to LAYOUT_tkl_f13_ansi_split_bs_rshift

    * [enhancement] add LAYOUT_tkl_f13_ansi

    * [enhancement] add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

    * [enhancement] add LAYOUT_tkl_f13_ansi_tsangan

    * [enhancenment] enable Community Layout support

commit 673b536
Merge: 3274e0a 71b77df
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 16:00:31 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 71b77df
Author: James Young <[email protected]>
Date:   Wed Jun 21 08:59:54 2023 -0700

    Keebio Cepstrum Configurator Touch-Up (qmk#21310)

    * [enhancement] remove redundant layout data

    Remove the redundant layout data from the keyboard-level `info.json`.

    * [enhancement] correct JSON syntax in rev1/info.json

    * [enhancement] friendly-format rev1/info.json

    * [enhancement] correct layout data

commit 3274e0a
Merge: 08ba8a0 ecca9c5
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 03:05:47 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit ecca9c5
Author: lalalademaxiya1 <[email protected]>
Date:   Wed Jun 21 11:05:07 2023 +0800

    Add Keychron C2 Pro (qmk#20701)

    Co-authored-by: Drashna Jaelre <[email protected]>
    Co-authored-by: adophoxia <[email protected]>
    Co-authored-by: jack <[email protected]>

commit 08ba8a0
Merge: 6373543 595d393
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 03:02:34 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 595d393
Author: jonylee@hfd <[email protected]>
Date:   Wed Jun 21 11:01:43 2023 +0800

    [Keyboard] Add Monsgeek M5 (qmk#21182)

    Co-authored-by: adophoxia <[email protected]>
    Co-authored-by: jack <[email protected]>

commit 6373543
Merge: dad41bd 2f1cac6
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 02:58:50 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit dad41bd
Author: James Young <[email protected]>
Date:   Tue Jun 20 19:58:44 2023 -0700

    ProtoTypist PT-60 Refactor (qmk#21322)

commit 2f1cac6
Author: Albert Y <[email protected]>
Date:   Wed Jun 21 10:58:13 2023 +0800

    [Docs] Code markdown amendment (qmk#21323)

commit c69f82f
Merge: 6ec91a7 7753249
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 02:30:16 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 7753249
Author: James Young <[email protected]>
Date:   Tue Jun 20 19:29:44 2023 -0700

    NovelKeys NK+: correct layout data (qmk#21317)

    * NovelKeys NK+: correct layout data

    Add key sizes to the layout data.

    * [refactor] rename LAYOUT to LAYOUT_65_xt_ansi_blocker_tsangan

commit 6ec91a7
Merge: ffdc70b 42cd55e
Author: QMK Bot <[email protected]>
Date:   Wed Jun 21 00:33:07 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 42cd55e
Author: Jack Humbert <[email protected]>
Date:   Tue Jun 20 20:32:32 2023 -0400

    Planck Matrix Fixes (qmk#21196)

    * fix non-default keymap compiling, initial matrix state, watchdog options

    * fix: allow planck/rev7 to be used with ENCODER_ENABLE = no

    * chore: update function name on all cases.

    * remove old midi tone option

    Co-authored-by: Ryan <[email protected]>

    * fixes abhixec's planck keymap

    * add audio enable condition to abhixec's planck keymap

    * add audio enable condition to all muse includes

    * Revert "add audio enable condition to all muse includes"

    This reverts commit 9779e90.

    * Revert "add audio enable condition to abhixec's planck keymap"

    This reverts commit 24c742a.

    * Revert "fixes abhixec's planck keymap"

    This reverts commit 4bb085d.

    ---------

    Co-authored-by: Peter.Falken <[email protected]>
    Co-authored-by: Ryan <[email protected]>

commit ffdc70b
Author: Nick Brassel <[email protected]>
Date:   Wed Jun 21 08:41:49 2023 +1000

    Consolidate `KEYBOARD_OUTPUT`+`KEYMAP_OUTPUT`=>`INTERMEDIATE_OUTPUT` (qmk#21272)

commit 45dc1cc
Author: James Young <[email protected]>
Date:   Tue Jun 20 15:40:31 2023 -0700

    EC Pro X JIS Layout Touch-Up (qmk#21260)

    * [refactor] update `info.json` for readability

    - sort the JSON objects representing the keyboard's keys in the order:
      - label, matrix, x, y, w, h
    - convert numeric JSON values to integers where appropriate

    * [refactor] remove key labels from `info.json`

    * [refactor] keymap refactor

    - grid-align keycodes

    * [bugfix] move Enter key to home row

    Moves the JSON object representing the Enter key to the home row.

    Fixes an issue that resulted in correct key assignment only if the
    keymap being compiled/flashed was based upon the `via` keymap.

commit ac14fce
Author: James Young <[email protected]>
Date:   Tue Jun 20 10:18:16 2023 -0700

    Kalakos Bahrnob65 Configurator Layout Touch-Up (qmk#21309)

    * [enhancement] add matrix diagram

    * [refactor] friendly-format info.json

    * [enhancement] remove key overlaps

commit a9f49a0
Merge: 01cfc72 85b8044
Author: QMK Bot <[email protected]>
Date:   Tue Jun 20 17:17:10 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 85b8044
Author: James Young <[email protected]>
Date:   Tue Jun 20 10:16:35 2023 -0700

    KJ-Modify RS40 Configurator Touch-Up (qmk#21311)

    * [refactor] friendly-format info.json

    * [enhancement] remove key overlap

    Fix a key overlap in the Configurator rendering between LCtrl and Fn2.

    * [enhancement] replace store links with product links

    Replace URLs that point to the vendor's shop with URLs to the vendor's
    product listing.

commit 01cfc72
Merge: 965cfec 45c52c7
Author: QMK Bot <[email protected]>
Date:   Tue Jun 20 15:42:27 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 45c52c7
Author: lalalademaxiya1 <[email protected]>
Date:   Tue Jun 20 23:41:45 2023 +0800

    [Keyboard] Add Keychron C1 Pro (qmk#20700)

    Co-authored-by: adophoxia <[email protected]>
    Co-authored-by: Drashna Jaelre <[email protected]>
    Co-authored-by: jack <[email protected]>

commit 965cfec
Merge: a2e2d92 958cae3
Author: QMK Bot <[email protected]>
Date:   Tue Jun 20 15:39:02 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 958cae3
Author: Roberts Kursitis <[email protected]>
Date:   Tue Jun 20 18:38:26 2023 +0300

    [Keyboard] Add Alisaie (qmk#21266)

commit a2e2d92
Merge: d98b60c 0abe312
Author: QMK Bot <[email protected]>
Date:   Tue Jun 20 15:36:05 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 0abe312
Author: Derek <[email protected]>
Date:   Tue Jun 20 11:35:23 2023 -0400

    [Keyboard] Add bigsmoothknob (qmk#21265)

    Co-authored-by: Joel Challis <[email protected]>
    Co-authored-by: jack <[email protected]>

commit d98b60c
Author: jonylee@hfd <[email protected]>
Date:   Tue Jun 20 10:31:46 2023 +0800

    Move kb83 keyboard (qmk#20761)

    * move hfdkb/keyboard_sw/k83 --> inland/kb83

    * move hfdkb/keyboard_sw/k83 --> inland/kb83

    * Update data/mappings/keyboard_aliases.hjson

    * Update keyboard_aliases.hjson

    * fixed  the Configurator layout data

    * fixed the Configurator layout data

    * Revert "Update keyboard_aliases.hjson"

    This reverts commit c085c54.

    * Revert "fixed  the Configurator layout data"

    * Update keyboard_aliases.hjson

    * Update info.json

commit 808228c
Merge: be6f92c 7bd1d18
Author: QMK Bot <[email protected]>
Date:   Tue Jun 20 01:56:07 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 7bd1d18
Author: Drashna Jaelre <[email protected]>
Date:   Mon Jun 19 18:55:27 2023 -0700

    [Docs] Add note about `ENABLE_COMPILE_KEYCODE` to docs (qmk#21290)

    Co-authored-by: Ryan <[email protected]>

commit be6f92c
Merge: b749a5f 31e39a9
Author: QMK Bot <[email protected]>
Date:   Tue Jun 20 01:46:21 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 31e39a9
Author: James Young <[email protected]>
Date:   Mon Jun 19 18:45:47 2023 -0700

    dnworks SBL Community Layout Support and Touch-Up (qmk#21267)

commit b749a5f
Author: jack <[email protected]>
Date:   Mon Jun 19 13:59:35 2023 -0600

    Fixup `nightly_boards/n40_o` (qmk#21307)

commit c4a67d3
Author: jack <[email protected]>
Date:   Mon Jun 19 09:46:27 2023 -0600

    Remove encoder in-matrix workaround code (qmk#20389)

commit 74fbd5a
Author: jack <[email protected]>
Date:   Mon Jun 19 06:10:25 2023 -0600

    Fixup `dekunukem/duckypad` (qmk#21298)
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@waffle87 @jesperhellberg
Fixup dekunukem/duckypad (qmk#21298)
d3ff0a5
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@waffle87 @thismarvin
Fixup dekunukem/duckypad (qmk#21298)
f2a39b3
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@waffle87 @akeep
Fixup dekunukem/duckypad (qmk#21298)
e1e4f87
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@waffle87 @csolje
Fixup dekunukem/duckypad (qmk#21298)
7b194ce
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@waffle87 @jashort
Fixup dekunukem/duckypad (qmk#21298)
507ddf9
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@waffle87 @autoferrit
Fixup dekunukem/duckypad (qmk#21298)
a554c93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waffle87 @zvecr