Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional layouts to dactyl_manuform variants #20688

Merged
merged 5 commits into from
May 20, 2023
Merged

add additional layouts to dactyl_manuform variants #20688

merged 5 commits into from
May 20, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented May 3, 2023 •
edited
Loading

Description

LAYOUT_split_3x5_3

  • 4x5
  • 4x5_5
  • 4x6_5

LAYOUT_split_3x6_3

  • 4x6_5

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
add "LAYOUT_split_3x5_3"
4ceeb8f 
variants:
- 4x5
- 4x5_5
- 4x6_5
dunk2k added 2 commits May 3, 2023 17:04
@dunk2k
Update info.json
6e9a842 
offset lint error corrections
@dunk2k
Update keymap.c
868faac
@github-actions github-actions bot added the keymap label May 3, 2023
@dunk2k
Update info.json
46de32f 
add "LAYOUT_split_3x6_3" to variant(s):
- 4x6_5
- Appended `community_layouts` element
@dunk2k dunk2k changed the title add "LAYOUT_split_3x5_3" to keyboards/handwired/dactyl_manuform add additional layouts to dactyl_manuform variants May 3, 2023
@drashna drashna requested a review from a team May 4, 2023 05:44
@dunk2k
add readme.md
3ffc946 
Added diagrams, per variant, to show QMK layout(s) against variant's key matrix
@dunk2k
Copy link
Contributor Author

dunk2k commented May 8, 2023

@manna-harbour : Not that it's required, but with LAYOUT_split_3x5_3 in place in this PR, removing keymap manna-harbour_miryoku would produce same result when compiling/flashing with -km manna-harbour_miryoku?

@manna-harbour
Copy link
Contributor

Not that it's required, but with LAYOUT_split_3x5_3 in place in this PR, removing keymap manna-harbour_miryoku would produce same result when compiling/flashing with -km manna-harbour_miryoku?

See #20371 (comment)

@dunk2k
Copy link
Contributor Author

dunk2k commented May 8, 2023 •
edited
Loading

See #20371 (comment)

@manna-harbour Thanks for response

@tzarc tzarc merged commit d1395ca into qmk:develop May 20, 2023
@dunk2k dunk2k deleted the DacMan_split3x5_3 branch May 20, 2023 12:10
@dunk2k dunk2k mentioned this pull request May 24, 2023
Closed
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@dunk2k @coquizen
add additional layouts to dactyl_manuform variants (qmk#20688)
c64297c
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@dunk2k @autoferrit
add additional layouts to dactyl_manuform variants (qmk#20688)
fdcb063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dunk2k @manna-harbour @drashna @tzarc