Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertex/angle65 WS2812 pin fix #20653

Merged
merged 2 commits into from
May 1, 2023
Merged

Vertex/angle65 WS2812 pin fix #20653

merged 2 commits into from
May 1, 2023

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented May 1, 2023 •
edited
Loading

Description

Follow up to #20514 — use WS2812_DI_PIN on develop branch.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team May 1, 2023 12:08
@tzarc tzarc added the bug label May 1, 2023
fauxpark
fauxpark requested changes May 1, 2023
View reviewed changes
keyboards/vertex/angle65/config.h Outdated Show resolved Hide resolved
@filterpaper filterpaper requested a review from fauxpark May 1, 2023 23:20
@waffle87 waffle87 merged commit 50a8287 into qmk:develop May 1, 2023
@filterpaper filterpaper deleted the vertex-angle65-ws2812 branch May 2, 2023 00:14
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@filterpaper @coquizen
Vertex/angle65 WS2812 pin fix (qmk#20653)
b81b1ce
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@filterpaper @autoferrit
Vertex/angle65 WS2812 pin fix (qmk#20653)
8d468a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filterpaper @tzarc @fauxpark @waffle87