Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fancytech Fancyalice66 #20647

Merged
merged 36 commits into from
May 18, 2023
Merged

Add Fancytech Fancyalice66 #20647

merged 36 commits into from
May 18, 2023

Conversation

adophoxia
Copy link
Contributor

Description

A re-attempt of #17491, but updated to be more in line with current QMK standards, i.e, DD-configuration and removal of action_exec hack for encoders.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 1, 2023
@adophoxia @zvecr
Update via keymap.
6f91542 
Removed extra encoder mapping layers.

Co-authored-by: Joel Challis <[email protected]>
@adophoxia adophoxia requested a review from zvecr May 2, 2023 00:46
fauxpark
fauxpark requested changes May 2, 2023
View reviewed changes
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/fancyalice66.c Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/config.h Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes May 2, 2023
View reviewed changes
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
adophoxia and others added 8 commits May 1, 2023 21:41
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
16454d7 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
f4d43e8 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
adeb35a 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
835f733 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
2c2404d 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
ef8760c 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
94bf82d 
Co-authored-by: Ryan <[email protected]>
@adophoxia @fauxpark
Update keyboards/fancytech/fancyalice66/info.json
43dd386 
Co-authored-by: Ryan <[email protected]>
@adophoxia adophoxia requested a review from fauxpark May 2, 2023 16:46
waffle87
waffle87 requested changes May 13, 2023
View reviewed changes
keyboards/fancytech/fancyalice66/fancyalice66.c Show resolved Hide resolved
keyboards/fancytech/fancyalice66/fancyalice66.c Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/info.json Outdated Show resolved Hide resolved
keyboards/fancytech/fancyalice66/config.h Outdated Show resolved Hide resolved
@adophoxia adophoxia requested a review from waffle87 May 14, 2023 14:59
@adophoxia adophoxia requested a review from drashna May 14, 2023 14:59
@drashna drashna requested a review from a team May 18, 2023 08:14
@waffle87 waffle87 merged commit a4771e4 into qmk:master May 18, 2023
2 of 3 checks passed
@adophoxia adophoxia mentioned this pull request May 20, 2023
Merged
7 tasks
sudish added a commit to sudish/qmk_firmware that referenced this pull request May 21, 2023
@sudish
Merge remote-tracking branch 'upstream/master'
55d4dab 
* upstream/master: (52 commits)
  `qmk generate-make-dependencies` improvements (qmk#21001)
  scramble: Add XOSC delay for startup (qmk#20991)
  [Keyboard] Add Fancytech Fancyalice66 (qmk#20647)
  Define RGB_DI_PIN directly instead of using another define (qmk#20983)
  Add Cepstrum Rev. 1 Keyboard (qmk#20721)
  [Keyboard] Add Moondrop Dash75 (qmk#20890)
  Revert to last known working version (qmk#20967)
  Bump anothrNick/github-tag-action from 1.64.0 to 1.65.0 (qmk#20964)
  Update tg4x RGB LED count (qmk#20955)
  Fix EEPROM_DRIVER=legacy_stm32_flash (qmk#20457)
  Generate `make` dependency file during build for info.json's etc. (qmk#20451)
  hazel/bad_wings update  (qmk#20947)
  jotix keymap update (qmk#20902)
  Far better VSCode intellisense support using clangd. (qmk#20382)
  Add new keyboard "Ergomirage" (qmk#20655)
  [Keyboard] Add Zwag75 keyboard (qmk#20757)
  [Keyboard] Add kibou/fukuro (qmk#20771)
  [Keyboard] Add Teleport TKL (qmk#20469)
  momokai tap_* rgb modes and bootmagic key update (qmk#20126)
  [Keymap] Add caps word enable to dshields keymaps (qmk#20862)
  ...
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@adophoxia @zvecr
@fauxpark @waffle87 @drashna @coquizen
[Keyboard] Add Fancytech Fancyalice66 (qmk#20647)
b7997d1 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@adophoxia @zvecr
@fauxpark @waffle87 @drashna @autoferrit
[Keyboard] Add Fancytech Fancyalice66 (qmk#20647)
051c25a 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
@adophoxia adophoxia deleted the fancytech-fancyalice66 branch June 27, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adophoxia @drashna @fauxpark @zvecr @waffle87