Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp dactyl_manuform readme.md #20395

Merged
merged 14 commits into from
Jul 7, 2023
Merged

Revamp dactyl_manuform readme.md #20395

merged 14 commits into from
Jul 7, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Apr 9, 2023

Description

Updated contents of dactyl_manuform readme.md to reflect current state of QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
Copy link
Contributor Author

dunk2k commented Apr 10, 2023

Updating a readme.md file and build check fails - can someone rectify?

@daskygit
Copy link
Member

The CI build failing doesn't immediately disqualify the PR from being merged, just a tool to help the reviewer.

@dunk2k
Copy link
Contributor Author

dunk2k commented Apr 11, 2023 •
edited
Loading

The CI build failing doesn't immediately disqualify the PR from being merged, just a tool to help the reviewer.

@daskygit appreciate your response, thank you

@dunk2k dunk2k changed the title Revamp dactyl_manuform readme.md Revamp dactyl_manuform readme.md May 7, 2023
dunk2k added 3 commits May 8, 2023 16:54
@dunk2k
Update readme.md
1420291
@dunk2k
Update readme.md
3c83566 
- changed wording of Miryoku section
- grammar corrections
@dunk2k
Update readme.md
5f5a6bb
@drashna drashna requested a review from a team May 20, 2023 21:13
@tzarc tzarc merged commit 9e33197 into qmk:develop Jul 7, 2023
@dunk2k dunk2k deleted the dm_readme branch July 7, 2023 17:04
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@dunk2k @jesperhellberg
Revamp dactyl_manuform readme.md (qmk#20395)
ec3738b
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@dunk2k @thismarvin
Revamp dactyl_manuform readme.md (qmk#20395)
0255154
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@dunk2k @akeep
Revamp dactyl_manuform readme.md (qmk#20395)
a9a81f7
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@dunk2k @csolje
Revamp dactyl_manuform readme.md (qmk#20395)
c3823bd
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@dunk2k @autoferrit
Revamp dactyl_manuform readme.md (qmk#20395)
3db55f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunk2k @daskygit @drashna @tzarc