Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS2812 driver improvements #20262

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

fauxpark
Copy link
Member

Description

  • Added custom driver type; cleaned up oddforge/vea to use it
  • Tweaked defines for I2C driver
  • Renamed ws2812.c to ws2812_bitbang.c to eliminate special case in common_features.mk

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team March 28, 2023 19:05
@fauxpark fauxpark merged commit 647c283 into qmk:develop Mar 30, 2023
@fauxpark fauxpark deleted the ws2812-driver-improvements branch March 30, 2023 01:21
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants