Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Some metadata on QGF/QFF files #20101

Merged
merged 18 commits into from
Mar 10, 2024
Merged

[Feature] Some metadata on QGF/QFF files #20101

merged 18 commits into from
Mar 10, 2024

Conversation

elpekenin
Copy link
Contributor

Description

As per @tzarc's request, some metadata on the files generated.

I also moved some duplicated code into a shared function. There's still a lot of duplication bewtween between fonts and images, but didn't feel like rewriting everything.

Removed a couple of file.close() along the way, as the context manager (aka with ... block) already closes them when we leave its scope.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Mar 12, 2023
@elpekenin
Copy link
Contributor Author

Btw, i can happily add more metadata, just let me know what else we could/should have

@drashna drashna requested review from tzarc and a team March 21, 2023 03:26
@github-actions github-actions bot added CI core documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 31, 2023
@github-actions github-actions bot removed keyboard keymap documentation core via Adds via keymap and/or updates keyboard for via support CI labels Jun 3, 2023
zvecr
zvecr requested changes Jun 3, 2023
View reviewed changes
lib/python/qmk/painter.py Outdated Show resolved Hide resolved
@tzarc tzarc added breaking_change_2024q1 and removed stale Issues or pull requests that have become inactive without resolution. breaking_change_2023q4 labels Nov 26, 2023
@zvecr zvecr changed the base branch from master to develop February 16, 2024 13:43
@elpekenin elpekenin mentioned this pull request Feb 17, 2024
Open
14 tasks
@tzarc tzarc added breaking_change_2024q2 develop-fast-track Intended to be merged early in the next develop cycle. and removed breaking_change_2024q1 labels Feb 25, 2024
@tzarc tzarc requested a review from a team March 9, 2024 23:22
@tzarc tzarc removed the awaiting_pr Relies on another PR to be merged first label Mar 9, 2024
@zvecr zvecr merged commit c5225ab into qmk:develop Mar 10, 2024
4 of 5 checks passed
@elpekenin elpekenin deleted the feature/image-info branch March 10, 2024 08:20
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@elpekenin @mechlovin
[Feature] Some metadata on QGF/QFF files (qmk#20101)
660eb17
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@elpekenin @mechlovin
[Feature] Some metadata on QGF/QFF files (qmk#20101)
56a2e53
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@elpekenin @mechlovin
[Feature] Some metadata on QGF/QFF files (qmk#20101)
201bfb1
0x647262 pushed a commit to 0x647262/qmk_firmware that referenced this pull request Apr 26, 2024
@elpekenin @0x647262
[Feature] Some metadata on QGF/QFF files (qmk#20101)
6ea674f
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
@elpekenin @PepperLola
[Feature] Some metadata on QGF/QFF files (qmk#20101)
ae0085f
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@elpekenin @whoisjordangarcia
[Feature] Some metadata on QGF/QFF files (qmk#20101)
6e98b37
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@elpekenin @nuphy-src
[Feature] Some metadata on QGF/QFF files (qmk#20101)
553ce1a
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@elpekenin @AJO-Python
[Feature] Some metadata on QGF/QFF files (qmk#20101)
f99daed
jrtex pushed a commit to jrtex/qmk_firmware that referenced this pull request Jul 13, 2024
@elpekenin
[Feature] Some metadata on QGF/QFF files (qmk#20101)
ce39421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
awaiting review cli qmk cli command develop-fast-track Intended to be merged early in the next develop cycle. python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elpekenin @drashna @tzarc @zvecr