Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout macro keys with no matrix position #20033

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fix layout macro keys with no matrix position #20033

merged 2 commits into from
Mar 13, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 6, 2023 •
edited
Loading

Description

Some are typos breaking the 1:1 mapping, some are simply missing the corresponding key name in the second half of the macro.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 6, 2023 12:37
@drashna drashna requested a review from a team March 10, 2023 09:22
@fauxpark fauxpark merged commit cf5e9d1 into qmk:develop Mar 13, 2023
@fauxpark fauxpark deleted the fix-invalid-layout-macros branch March 13, 2023 12:02
@fauxpark fauxpark mentioned this pull request Mar 25, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@fauxpark @coquizen
Fix layout macro keys with no matrix position (qmk#20033)
06801b1
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna