Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Update Work Louder boards #19976

Closed
wants to merge 6 commits into from
Closed

[Keyboard] Update Work Louder boards #19976

wants to merge 6 commits into from

Conversation

drashna
Copy link
Member

@drashna drashna commented Mar 1, 2023

Description

Update the Work Board to data driven config, as well as relocate via config, etc.

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team March 1, 2023 01:10
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 1, 2023
zvecr
zvecr requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixture of user/kb eeprom calls

keyboards/work_louder/work_board/work_board.c Outdated Show resolved Hide resolved
keyboards/work_louder/work_board/work_board.c Outdated Show resolved Hide resolved
@drashna drashna marked this pull request as draft March 1, 2023 01:49
@drashna drashna changed the title [Keyboard] Update Work Louder Work Board [Keyboard] Update Work Louder boards Mar 1, 2023
@drashna drashna marked this pull request as ready for review March 6, 2023 19:40
@drashna drashna closed this Mar 9, 2023
@drashna drashna deleted the keyboard/work_louder branch March 9, 2023 22:07
@drashna drashna restored the keyboard/work_louder branch March 9, 2023 22:08
@drashna drashna reopened this Mar 9, 2023
@drashna drashna closed this Mar 9, 2023
@drashna drashna deleted the keyboard/work_louder branch March 9, 2023 22:10
@drashna drashna restored the keyboard/work_louder branch March 9, 2023 22:11
@drashna drashna reopened this Mar 9, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 17, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@zvecr zvecr zvecr requested changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @fauxpark @zvecr