[Cleanup] Quantum Painter #19825
Merged
[Cleanup] Quantum Painter #19825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
approved these changes
Mar 19, 2023
|
SHA1's all match for all QP-enabled boards in the repo. |
What does this mean? "Everything compiles"? 😅 |
Yes, generated binaries are identical before and after this PR is applied. |
|
Merge conflicts here. |
tzarc
requested changes
Mar 25, 2023
Co-authored-by: Nick Brassel <[email protected]>
tzarc
approved these changes
Mar 25, 2023
|
SHA1's still match. |
nicsuzor
pushed a commit
to nicsuzor/qmk_firmware
that referenced
this pull request
Mar 28, 2023
Co-authored-by: Nick Brassel <[email protected]>
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Nick Brassel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just some tidying of QP's codebase, adding some
typedefs here and there to get rid of boilerplatestructSome of these types are defined in.cfiles, i dont know if they should be moved to.h, i also renamed a couple of them, appending_tA couple of minor changes too
QP_MIN__attribute__((packed))withQP_PACKEDTested by compiling my keyboard's files and display worked fine. Didn't test exhaustively tho
Haven't linted, as i think the changes haven't mess up formatting, im gonna let CI warn and fix offending files if any.Types of Changes
Issues Fixed or Closed by This PR
Checklist