Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning when not valid work-tree #19475

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 2, 2023

Description

When trying to build via zip, the usual error is ⚠ "git describe --abbrev=6 --dirty --always --tags" returned error code 128 which isnt the most descriptive. This updates to produce the following:

$ make clean kprepublic/jj4x4:default
Deleting .build/ ... done.
WARNING: Target folder is not a git repo.
 Please consider following https://docs.qmk.fm/#/newbs_getting_started.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 2, 2023
@zvecr zvecr requested a review from a team January 2, 2023 04:43
@tzarc tzarc merged commit 4b2fd42 into qmk:develop Jan 2, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants