-
-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KB30 keyboard #19395
Merged
Merged
Add KB30 keyboard #19395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Hi, I just want to PR kb30 keyboard. I don't know why this PR contain dokb16? I delete dokb16 in my github, is that mean this PR do not contain dokb16? And now ,this PR show "Merging is blocked.The base branch restricts merging toautthorized users.
Could you tell me how can I do next? Thank you!
原始邮件
发件人:"Joel Challis"< ***@***.*** >;
发件时间:2022/12/22 8:45
收件人:"qmk/qmk_firmware"< ***@***.*** >;
抄送人:"DOIO2022"< ***@***.*** >;"Author"< ***@***.*** >;
主题:Re: [qmk/qmk_firmware] Add KB30 keyboard (PR #19395)
Why does this also contain keyboards/doio/dokb16 ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
drashna
requested changes
Dec 23, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna Hi, as all the checks have passed, does it merge automatically? or how should I proceed? |
drashna
approved these changes
Dec 31, 2022
tzarc
approved these changes
Jan 1, 2023
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jan 2, 2023
Co-authored-by: Drashna Jaelre <[email protected]>
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
Co-authored-by: Drashna Jaelre <[email protected]>
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
Co-authored-by: Drashna Jaelre <[email protected]>
barrettclark
added a commit
to barrettclark/qmk_firmware
that referenced
this pull request
Mar 6, 2023
* upstream/master: (1825 commits) A comma was missing (qmk#19507) Bump anothrNick/github-tag-action from 1.56.0 to 1.57.0 (qmk#19502) Add SapuSeven MacroPad12 (qmk#19466) feat(kprepublic/bm60hsrgb_poker): update carlosala keymap (qmk#19426) [Keyboard] Stop LED1 from flashing on layer change (qmk#19427) Allow for specifying the number of symbols to output. (qmk#19497) Add `qmk mass-compile`, which intends to supercede `qmk multibuild` whilst providing support for filtering as per data-driven definitions. (qmk#18971) Bump anothrNick/github-tag-action from 1.55.0 to 1.56.0 (qmk#19494) Fix github URL for the atreyu maintainer. (qmk#19476) adpenrose/akemipad fixes (qmk#19477) [Keymap] Add Neo2-based keymap for Planck keyboard (qmk#19173) [Keyboard] Add community layout support to Piantor (qmk#19455) Keyboard/fix work louder micro (qmk#18968) Add docs to cover recent LAYOUT_all lint checks (qmk#19393) WSL `qmk flash firmware.bin` workaround (qmk#19434) CLI flashers should allow files outside qmk_firmware folder (qmk#19454) [Keyboard] Add Quarkeys Z60, reorganized keyboard file directory (qmk#19404) Add KB30 keyboard (qmk#19395) Atreyu rev2 (qmk#19443) Fixes unicode_map declaration example (qmk#19450) ...
7 tasks
7 tasks
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jun 12, 2023
Co-authored-by: Drashna Jaelre <[email protected]>
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jun 15, 2023
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add KB30 keyboard
Types of Changes
Issues Fixed or Closed by This PR
Checklist