DZTECH Endless80 Touch-Up #19339
Merged
DZTECH Endless80 Touch-Up #19339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespace-only change, for readability.
- apply four-space indent - grid-align keycodes
- apply four-space indent - grid-align keycodes
The `default` keymap was seemingly written for a TKL PCB with Split Backspace support and a Tsangan bottom row, but the only layout macro currently available is 2u Backspace and a Standard bottom row. This commit removes the Split Backspace `Delete` keycode, and adds a `KC_APP` (Context Menu) keycode to the bottom row.
noroadsleft
added
bug
enhancement
keyboard
keymap
via
fauxpark
approved these changes
Dec 15, 2022
drashna
approved these changes
Dec 15, 2022
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
sbhal
pushed a commit
to sbhal/qmk_firmware
that referenced
this pull request
Dec 30, 2022
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
endless80.hLAYOUT_tkl_ansiandLAYOUT_tkl_ansi_tsangan)defaultkeymapThe originally-submitted
defaultkeymap seemed to have been written for a TKL PCB with Split Backspace support and a Tsangan bottom row, but the only layout macro that was submitted was 2u Backspace with a Standard bottom row.I updated the
defaultkeymap to match theviakeymap, which seemed to be accurate.The product pages I found say that there is a solderable PCB with ISO support, but I found no references to how the ISO Enter is configured in the switch matrix.
cc @moyi4681 (keyboard maintainer)
Types of Changes
Issues Fixed or Closed by This PR
Checklist