Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idobao ID80 V2: Partial Data-Driven Conversion #19247

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Idobao ID80 V2: Partial Data-Driven Conversion #19247

merged 4 commits into from
Dec 8, 2022

Conversation

noroadsleft
Copy link
Member

Description

Noticed the ID80 V2 ANSI and ISO boards had access to each other's layout macros in Configurator, but each PCB is single-layout. Found going data driven was a less-involved changeset, so did a partial conversion.

Moves the layout macros and the rules.mk settings to data-driven configuration.

@IDOBAOKB, @vinorodrigues, @sigprof, @cwr10010 (keyboard maintainers)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested review from sigprof and a team December 6, 2022 23:16
vinorodrigues
vinorodrigues approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@vinorodrigues vinorodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from my side. Looks OK to me.
Aside: ID no longer mnf. the v2 PCB, so any edits here would just be clean-up.

@tzarc tzarc merged commit de92e8b into qmk:master Dec 8, 2022
@noroadsleft noroadsleft deleted the cf/idobao_id80_v2 branch December 8, 2022 17:59
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@noroadsleft @crembz
Idobao ID80 V2: Partial Data-Driven Conversion (qmk#19247)
7e801cd
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@noroadsleft
Idobao ID80 V2: Partial Data-Driven Conversion (qmk#19247)
ae54883
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@noroadsleft @ideas32
Idobao ID80 V2: Partial Data-Driven Conversion (qmk#19247)
c9e089b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinorodrigues vinorodrigues vinorodrigues approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noroadsleft @vinorodrigues @tzarc @fauxpark