Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sthlmkb/litl: fix layout macros #19244

Merged
merged 1 commit into from
Dec 11, 2022
Merged

sthlmkb/litl: fix layout macros #19244

merged 1 commit into from
Dec 11, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 6, 2022

Description

keyboards/sthlmkb/litl/litl.h:70:28: error: 'K1A' undeclared here (not in a function); did you mean 'KC_A'?
 { K10, K12, K14, K16, K18, K1A, }, \
                            ^~~

etc.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 6, 2022 10:25
noroadsleft
noroadsleft approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fauxpark fauxpark merged commit 7c72c5e into qmk:master Dec 11, 2022
@fauxpark fauxpark deleted the litl-fix-layout-macro branch December 11, 2022 07:00
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@fauxpark @crembz
sthlmkb/litl: fix layout macros (qmk#19244)
3be4461
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@fauxpark
sthlmkb/litl: fix layout macros (qmk#19244)
849f0b6
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@fauxpark @omikronik
sthlmkb/litl: fix layout macros (qmk#19244)
d5c994c
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@fauxpark @ideas32
sthlmkb/litl: fix layout macros (qmk#19244)
0a3b70e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @noroadsleft