Add Jabberwocky v2 firmware and reorganize #19014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
|
I've made a thread on the QMK Discord in this regard, but it's not clear to me why the CI build is failing. Anyone able to look at this? |
|
Okay, a rerun of CI fixed this. |
drashna
reviewed
Nov 11, 2022
drashna
reviewed
Nov 15, 2022
drashna
approved these changes
Nov 15, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
fauxpark
requested changes
Nov 16, 2022
keyboards/nopunin10did/jabberwocky/v2/keymaps/nopunin10did/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/nopunin10did/jabberwocky/v2/keymaps/nopunin10did/keymap.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
…d/qmk_firmware into jabberwocky-v2-clean
Co-authored-by: Ryan <[email protected]>
|
@fauxpark Can you have a look again? I ended up making a slightly different change than one you suggested, but it should accomplish the same goal. |
fauxpark
requested changes
Nov 18, 2022
fauxpark
approved these changes
Nov 18, 2022
keyboards/nopunin10did/jabberwocky/v1/keymaps/nopunin10did/keymap.c
Outdated
Show resolved
Hide resolved
…map.c Co-authored-by: Ryan <[email protected]>
thystips
pushed a commit
to thystips/qmk_firmware
that referenced
this pull request
Nov 24, 2022
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganizes the Jabberwocky firmware directory in QMK and adds the second generation Jabberwocky firmware (v2).
Types of Changes
Issues Fixed or Closed by This PR
Checklist