Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mode SixtyFive HI Layout Refactor #18823

Merged
merged 5 commits into from
Oct 23, 2022
Merged

Mode SixtyFive HI Layout Refactor #18823

merged 5 commits into from
Oct 23, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_all to LAYOUT_65_iso_blocker
  • add LAYOUT_65_iso_blocker_tsangan
  • minor keymap edits because the existing keymaps didn't make sense to me

cc @Gondolindrim (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
m65hi_alpha.h: add matrix diagram
2051134
@noroadsleft
rename LAYOUT_all to LAYOUT_65_iso_blocker
46c309b
@noroadsleft
add LAYOUT_65_iso_blocker_tsangan
99bbf3d
@noroadsleft
tidy-up keymaps
b5e9736 
- use four-space indent
- polish keycode grid alignment
@noroadsleft
touch-up keymaps
1d043d4 
Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 23, 2022
@noroadsleft noroadsleft requested a review from a team October 23, 2022 03:14
@zvecr zvecr merged commit 590ce13 into qmk:master Oct 23, 2022
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 23, 2022
@noroadsleft @tacahiroy
Mode SixtyFive HI Layout Refactor (qmk#18823)
2b9151f 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
@noroadsleft noroadsleft deleted the rf/mode_m65hi_alpha branch October 23, 2022 20:02
hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
@noroadsleft @hirakiuc
Mode SixtyFive HI Layout Refactor (qmk#18823)
10e9091 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@noroadsleft
Mode SixtyFive HI Layout Refactor (qmk#18823)
3d8909f 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@noroadsleft @thystips
Mode SixtyFive HI Layout Refactor (qmk#18823)
f7792b5 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@noroadsleft @ramonimbao
Mode SixtyFive HI Layout Refactor (qmk#18823)
282a4ab 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
Mode SixtyFive HI Layout Refactor (qmk#18823)
55650c5 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@noroadsleft @ChrisChrisLoLo
Mode SixtyFive HI Layout Refactor (qmk#18823)
cd176cf 
* m65hi_alpha.h: add matrix diagram

* rename LAYOUT_all to LAYOUT_65_iso_blocker

* add LAYOUT_65_iso_blocker_tsangan

* tidy-up keymaps

- use four-space indent
- polish keycode grid alignment

* touch-up keymaps

Switch one Page Down keycode for Page Up on the `default` keymap, and switch the Page Down and Page Up keycodes on the `via` keymap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr