Add encoder map support for GMMK Pro #18600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add encoder mapping to rev1 and rev2 variants (VIA keymap for ISO already has it) - Add `rules.mk` file to `default` keymap folders to utilize encoder mapping
github-actions
bot
added
keymap
via
drashna
approved these changes
Oct 5, 2022
fauxpark
approved these changes
Oct 5, 2022
|
Ty for merging, @drashna 👍 |
This was referenced Oct 5, 2022
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
Oct 12, 2022
* master: (147 commits) [Keyboard] Add waffling80 Rev B (qmk#18603) Enable mouse keys for momokai tap_trio (qmk#18614) [Keyboard] adafruit/macropad: Fix typo (qmk#18616) Product changes to 1up lineup (qmk#18382) width:2 → height:2 for spacetime thumb keys (qmk#18605) [Keyboard] Add encoder map support for GMMK Pro (qmk#18600) [Keyboard] Add waffling60 Rev D ANSI Hotswap (qmk#18579) [Keyboard] Add waffling60 Rev D Solder (qmk#18580) Added new issue template for "Other issues" (qmk#18578) docs: some typos (qmk#18582) RESET → QK_BOOT in nyhxis/nfr_70 (qmk#18607) Fixup builds for mechlovin/infinity87. (qmk#18604) fix: ps2_interrupt.c failed to compile (qmk#18597) Add C++ prerequisite for Fedora. (qmk#18602) [Keyboard] Add Nyhxis NFR-70 keyboard (qmk#17562) [Docs] Add a note about the print function. (qmk#17737) [Keyboard] Twig50 (qmk#18085) [Docs] Clarify how to use the bootloader LED for rp2040 (qmk#18585) Bump anothrNick/github-tag-action from 1.51.0 to 1.52.0 (qmk#18590) define `oled_write_ln_P` as `oled_write_ln` for non-AVR MCUs (qmk#18589) ...
quinnyo
pushed a commit
to quinnyo/qmk_firmware
that referenced
this pull request
Oct 21, 2022
aivalja
pushed a commit
to aivalja/qmk_firmware
that referenced
this pull request
Nov 7, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
|
What's the difference between the flag set here and this new one under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rules.mkfile todefaultkeymap folders to utilize encoder mappingTypes of Changes
Issues Fixed or Closed by This PR
Checklist