Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new issue templates for feature requests and bug reports #18576

Merged
merged 7 commits into from
Oct 4, 2022
Merged

Added new issue templates for feature requests and bug reports #18576

merged 7 commits into from
Oct 4, 2022

Conversation

Choromanski
Copy link
Contributor

Description

I have updated the issue templates for both Bug Reports and Feature Requests to use the new Syntax for issue forms.

Example issues can be created/tested on choromanski/qmk_firmware

Link to see new Bug report template in action

Link to see new Feature request template in action

Screenshots

Screenshots from my forked version

New Issue Page

image

Bug Report Page

Example Bug Report Issue
image

image

Feature Request Page

Example Feature Request Issue
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the CI label Oct 3, 2022
@Choromanski
Copy link
Contributor Author

Any and all input on this PR would be greatly appreciated.

I will look into doing the same with the PR forms.

@Choromanski
Copy link
Contributor Author

Feel free to use my branch choromanski/qmk_firmware to test out the new feature.

@drashna drashna requested a review from a team October 4, 2022 00:07
fauxpark
fauxpark requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Unix line endings.

@Choromanski
Copy link
Contributor Author

Please use Unix line endings.

Done

fauxpark
fauxpark requested changes Oct 4, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 4, 2022 01:18
tzarc
tzarc approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@tzarc tzarc merged commit dc52347 into qmk:master Oct 4, 2022
@Choromanski Choromanski mentioned this pull request Oct 4, 2022
Merged
14 tasks
4pplet added a commit to 4pplet/qmk_firmware that referenced this pull request Oct 4, 2022
@4pplet
Squashed commit of the following:
36c474b 
commit daf2552bdb579376ea13f467c3c1bac07e6a99a4
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:52:04 2022 +0200

    cont

commit fa252981fb61fd9f1e5d46846266291de6a7e19d
Merge: 135153a7a4 78c4907
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:49:15 2022 +0200

    Merge remote-tracking branch 'upstream/master' into waffling80_rev_b

commit 135153a7a417cb7cc3725b43eeb22287f251bc6e
Merge: ed74dbe24b 9ebb5a7bb3
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:48:27 2022 +0200

    Merge branch 'waffling80_rev_b' of https://github.com/4pplet/qmk_firmware into waffling80_rev_b

commit ed74dbe24bf7918898d1c3193f7c36115644eace
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:45:34 2022 +0200

    cont

commit 78c4907
Author: mmccoyd <[email protected]>
Date:   Mon Oct 3 19:17:08 2022 -0700

    [Docs] Clarify CAPS_WORD behaviors (qmk#18137)

    Co-authored-by: precondition <[email protected]>
    Co-authored-by: mmccoyd <[email protected]>
    Co-authored-by: Drashna Jaelre <[email protected]>

commit dc52347
Author: Brian Choromanski <[email protected]>
Date:   Mon Oct 3 21:42:56 2022 -0400

    Added new issue templates for feature requests and bug reports (qmk#18576)

    Co-authored-by: Ryan <[email protected]>

commit 88046b3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 4 08:51:57 2022 +1100

    Bump anothrNick/github-tag-action from 1.50.0 to 1.51.0 (qmk#18575)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 9ebb5a7bb329b1fe9a4d0091b61e1da94f0ffcc9
Author: 4pplet <[email protected]>
Date:   Mon Oct 3 22:14:13 2022 +0200

    cont

commit 079fc7a256d459ffab2e2c01d0ca1a287acc4e2e
Author: 4pplet <[email protected]>
Date:   Mon Oct 3 16:03:32 2022 +0200

    Update rev_b.h

commit e59f731f62fc9db26351d7552054c49ec7ea7649
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 22:36:36 2022 +0200

    cont, compiles properly, not tested on HW

commit 658b9afa374f485dee7245495747140361e9c48d
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 22:21:10 2022 +0200

    Update mcuconf.h

commit c4dc3944967917501ddf7e3dba0786072aa28604
Merge: 343666ad7f ee22f34
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 22:20:57 2022 +0200

    Merge remote-tracking branch 'upstream/master' into waffling80_rev_b

commit 343666ad7f0e1ea894beac9dc72ae4d4d496af61
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 19:45:06 2022 +0200

    adding draft for rev_b
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@Choromanski @fauxpark @quinnyo
Added new issue templates for feature requests and bug reports (qmk#1…
4c3d85d 
…8576)

Co-authored-by: Ryan <[email protected]>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@Choromanski @fauxpark
Added new issue templates for feature requests and bug reports (qmk#1…
86561ab 
…8576)

Co-authored-by: Ryan <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@Choromanski @fauxpark @ramonimbao
Added new issue templates for feature requests and bug reports (qmk#1…
03260ee 
…8576)

Co-authored-by: Ryan <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Choromanski @fauxpark @nolanseaton
Added new issue templates for feature requests and bug reports (qmk#1…
6ba3b8f 
…8576)

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Choromanski @tzarc @fauxpark