Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Anne Pro 2 c18 ISO variant support #18154

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Conversation

Johns-Q
Copy link
Contributor

@Johns-Q Johns-Q commented Aug 24, 2022

Description

Keyboard and keymap definition for the ISO layout variant of the Anne Pro 2 C18

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 26, 2022 02:50

#undef PRODUCT
// C18 is a macro
#define PRODUCT Anne Pro 2 c18-iso (QMK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this will need to be wrapped in double quotes in develop (#18183), or it will fail to compile. There is no change needed here.

@tzarc tzarc merged commit 1d194ac into qmk:master Oct 3, 2022
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants