Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add via support for 6key #18082

Merged
merged 9 commits into from
Sep 9, 2022
Merged

Add via support for 6key #18082

merged 9 commits into from
Sep 9, 2022

Conversation

Bratzworth
Copy link
Contributor

Adds via support for the 6key macropad

Description

Adds a new keymap to the 6key macropad, and moves the dip switch configuration from the default keymap to 6key.c. As a part of adding VIA support the vendor id was changed to be unique.

Also appropriately updates all references from LAYOUT to LAYOUT_all.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 17, 2022
keyboards/handwired/6key/config.h Outdated Show resolved Hide resolved
keyboards/handwired/6key/info.json Outdated Show resolved Hide resolved
keyboards/handwired/6key/keymaps/via/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/6key/keymaps/default/readme.md Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team August 17, 2022 03:32
@Bratzworth
Copy link
Contributor Author

is there any way to request a re-review of this?

keyboards/handwired/6key/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/6key/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/6key/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/6key/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/6key/info.json Outdated Show resolved Hide resolved
keyboards/handwired/6key/6key.h Outdated Show resolved Hide resolved
@Bratzworth Bratzworth requested review from zvecr and drashna and removed request for fauxpark and zvecr September 9, 2022 00:19
@zvecr zvecr merged commit 88555d8 into qmk:master Sep 9, 2022
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants