Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acheron Athena Layout Macro Refactor and Additions #17973

Merged
merged 11 commits into from
Aug 11, 2022
Merged

Acheron Athena Layout Macro Refactor and Additions #17973

merged 11 commits into from
Aug 11, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • physically arranges the LAYOUT_all macro
    • position K2E (Insert) moves up one row, to the place following K1E (right Backspace)
    • position K3E (Delete) moves up one row, to the place following K2D (Backslash)
  • adds QMK Configurator data
  • adds eight new layout macros (combinations of ANSI/ISO, split Backspace + split Right Shift/2u Backspace + 2.75u Right Shift, Standard/F13 Function Row)

cc @Gondolindrim (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 10, 2022
@noroadsleft noroadsleft requested a review from a team August 10, 2022 07:08
@Gondolindrim
Copy link
Contributor

Awesome, thanks @noroadsleft !

@drashna drashna merged commit 380465e into qmk:master Aug 11, 2022
@noroadsleft noroadsleft deleted the rf/acheron_athena branch August 17, 2022 17:19
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@noroadsleft @imhoffman
Acheron Athena Layout Macro Refactor and Additions (qmk#17973)
112bcab
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
Acheron Athena Layout Macro Refactor and Additions (qmk#17973)
6a839a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noroadsleft @Gondolindrim @drashna @fauxpark