Add Iris Rev. 7 #17967
Merged
Add Iris Rev. 7 #17967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4a23360ad163716a5cf51c54de9e18bac58bcdd6)
(cherry picked from commit 153464d21f54feecdf5f9bf89152efdcd34659e4)
(cherry picked from commit 6ac11b23a2d7eff20aad38f5f6ab1f499bb1d358)
(cherry picked from commit 4e99ef4dfd8d950a352c51368fb18dff64ea9451)
(cherry picked from commit e5c99cb8936b9b26b82620423b04971cd33bd514)
(cherry picked from commit b9cadd8cd35c887c6936612473ffe3dc479b610f)
(cherry picked from commit 2f9e97dd55cebdab65287f6547b0f2942510dfc0)
github-actions
bot
added
keyboard
keymap
via
drashna
requested changes
Aug 9, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
drashna
approved these changes
Aug 10, 2022
nooges
commented
Aug 11, 2022
|
|
||
| #ifdef ENCODER_MAP_ENABLE | ||
| const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = { | ||
| # if defined(KEYBOARD_keebio_iris_rev7) |
There was a problem hiding this comment.
Looking for some feedback here on if this is the right approach for handling differing numbers of encoders
There was a problem hiding this comment.
Not sure there is a great way to handle this, aside from having the keymap folder in the different revision folders.
But this should be okay, I think.
drashna
approved these changes
Aug 11, 2022
keyboard-magpie
approved these changes
Aug 11, 2022
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
6 tasks
6 tasks
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Iris Rev. 7
Types of Changes
Issues Fixed or Closed by This PR
Checklist