Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for Viendi8L #17943

Merged
merged 6 commits into from
Aug 11, 2022
Merged

Initial support for Viendi8L #17943

merged 6 commits into from
Aug 11, 2022

Conversation

Gondolindrim
Copy link
Contributor

Description

Adds support for Viendi 8L PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 7, 2022
@Gondolindrim Gondolindrim marked this pull request as ready for review August 7, 2022 21:00
fauxpark
fauxpark requested changes Aug 7, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing info.json.

keyboards/viendi8l/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/viendi8l/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/viendi8l/readme.md Outdated Show resolved Hide resolved
keyboards/viendi8l/readme.md Outdated Show resolved Hide resolved
drashna
drashna requested changes Aug 7, 2022
View reviewed changes
keyboards/viendi8l/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/viendi8l/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/viendi8l/config.h Outdated Show resolved Hide resolved
@Gondolindrim
Copy link
Contributor Author

Missing info.json.

Added in 2138db3

@drashna drashna requested a review from a team August 8, 2022 05:58
fauxpark
fauxpark requested changes Aug 8, 2022
View reviewed changes
keyboards/viendi8l/info.json Outdated Show resolved Hide resolved
keyboards/viendi8l/config.h Outdated Show resolved Hide resolved
@drashna drashna merged commit 9898d6f into qmk:master Aug 11, 2022
This was referenced Aug 16, 2022
Closed
Merged
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@Gondolindrim @fauxpark @imhoffman
[Keyboard] Add Viendi8L (qmk#17943)
c079da8 
Co-authored-by: Ryan <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Gondolindrim @fauxpark @nolanseaton
[Keyboard] Add Viendi8L (qmk#17943)
f7f3dc0 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gondolindrim @drashna @fauxpark