Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csc027/keymap-updates #17881

Merged
merged 6 commits into from
Aug 7, 2022
Merged

csc027/keymap-updates #17881

merged 6 commits into from
Aug 7, 2022

Conversation

csc027
Copy link
Contributor

@csc027 csc027 commented Aug 3, 2022

Description

  • Added media keys to keymaps.
  • Added hue/saturation macros to easily create HSV colors without the value (they mirror the HSV values).
  • Reverted tap code delays, since the benefit is less stable than leaving polling rate at default

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Aug 3, 2022
@drashna drashna requested a review from a team August 6, 2022 02:44
@keyboard-magpie keyboard-magpie merged commit 4267f0e into qmk:master Aug 7, 2022
@csc027 csc027 deleted the csc027/keymap-updates branch August 9, 2022 00:27
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@csc027 @imhoffman
csc027/keymap-updates (qmk#17881)
e128c70 
* Reverted to most usable configuration for RDP usage.

* Added some HSV color definitions without the value portion to allow using the existing value.

* Switched to using HSV and HS color definitions.

* Added media keys to the convenience layer.

* Updated make rules to enable media keys.

* Cleaned up planck make rules.
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@csc027 @nolanseaton
csc027/keymap-updates (qmk#17881)
a26c56c 
* Reverted to most usable configuration for RDP usage.

* Added some HSV color definitions without the value portion to allow using the existing value.

* Switched to using HSV and HS color definitions.

* Added media keys to the convenience layer.

* Updated make rules to enable media keys.

* Cleaned up planck make rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csc027 @drashna @keyboard-magpie