Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore kbfirmware exports #17687

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Ignore kbfirmware exports #17687

merged 1 commit into from
Jul 15, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 14, 2022

Description

While we shouldnt have to do this... 馃槩

  • Ignore kb.c/kb.h
  • Update Makefile ignores to be less verbose

Adding to ignore will then flag these files in the qmk lint CI workflow

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@qmk-ci
Copy link

qmk-ci bot commented Jul 14, 2022

QMK CI Run, PR #17687

Commit SHA1: 3d74e5ae049550aff307b30b214057fe061c3e08
  Base SHA1: be568177435c94a7c18217c5486e2df1062c3d73

Build succeeded. See the CI output for more information.

@zvecr zvecr requested a review from a team July 14, 2022 22:17
@tzarc tzarc requested a review from a team July 14, 2022 22:26
@zvecr zvecr merged commit 3c6765b into qmk:master Jul 15, 2022
WonderBeat pushed a commit to post-engineering/qmk_firmware that referenced this pull request Jul 16, 2022
* 'master' of github.com:qmk/qmk_firmware: (179 commits)
  [Keymap] Crkbd/thunderbird2086 (qmk#16973)
  Suavity Ehan Refactor (qmk#17694)
  feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761)
  FJLabs Solanis Refactor (qmk#17686)
  [Keyboard] add ProjectCain Relic (qmk#15577)
  [Keyboard] eHan Keyboard (qmk#15861)
  Move ins, home and pgup keys to the left (qmk#17690)
  [Keymap] emp keymap for keebio/iris (qmk#16858)
  Ignore kbfirmware exports (qmk#17687)
  [Keyboard] Added TutelPad keyboard (qmk#16975)
  [Keyboard] Add Chocofly v1 (qmk#17289)
  KB16-01: correct QMK Configurator key sequence (qmk#17670)
  Nayeon Community Layout support (qmk#17665)
  [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681)
  [Keyboard] Readme file correction (qmk#17674)
  KPrepublic BM80v2 ISO Refactor (qmk#17660)
  [Keyboard] MechWild BB Steno (qmk#17163)
  [Keyboard] Modelm101 teensy2 (qmk#16805)
  Ducky One 2 SF touch-up (qmk#17672)
  Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668)
  ...
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants