Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(develop)AP2: Enable support for WL EEPROM Driver #17506

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Jun 30, 2022

Description

Enable WL EEPROM driver support for both variant of the AnnePro2(C15/C18)

Tested only with the C18 variant but the C!5 uses the same NOR Flash with the exception of a different pin for the EXTERNAL_FLASH_SPI_SLAVE_SELECT_PIN

Nonetheless both variants compile:

C15 default keymap:

Ψ Compiling keymap with make --jobs=1 annepro2/c15:default


QMK Firmware 0.17.2
Making annepro2/c15 with keymap default

arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10.3-2021.10) 10.3.1 20210824 (release)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   40476       0   40476    9e1c annepro2_c15_default.bin


Size after:
   text    data     bss     dec     hex filename
      0   40476       0   40476    9e1c annepro2_c15_default.bin

Copying annepro2_c15_default.bin to qmk_firmware folder                                             [OK]
(Firmware size check does not yet support cortex-m0plus; skipping)

C18 default keymap:

Ψ Compiling keymap with make --jobs=1 annepro2/c18:default


QMK Firmware 0.17.2
Making annepro2/c18 with keymap default

arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10.3-2021.10) 10.3.1 20210824 (release)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text    data     bss     dec     hex filename
      0   40552       0   40552    9e68 annepro2_c18_default.bin


Size after:
   text    data     bss     dec     hex filename
      0   40552       0   40552    9e68 annepro2_c18_default.bin

Copying annepro2_c18_default.bin to qmk_firmware folder                                             [OK]
(Firmware size check does not yet support cortex-m0plus; skipping)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Jpe230 Jpe230 changed the title AP2: Enable support for WL EEPROM Driver (develop)AP2: Enable support for WL EEPROM Driver Jun 30, 2022
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on C18.

@tzarc tzarc requested a review from a team June 30, 2022 00:35
@tzarc tzarc merged commit 4f12457 into qmk:develop Jun 30, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Jpe230 Jpe230 deleted the annepro2_wl branch July 27, 2022 16:59
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants