Allow larger SPLIT_USB_TIMEOUT with default SPLIT_USB_TIMEOUT_POLL #17272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
May 31, 2022
zvecr
approved these changes
May 31, 2022
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
…mk#17272) * Switch SPLIT_USB_DETECT loop to uint16_t * Add assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into this issue earlier on Discord. The current
SPLIT_USB_TIMEOUT_POLLof10limits the maximum value ofSPLIT_USB_TIMEOUT. SettingSPLIT_USB_TIMEOUTabove the limit will cause the slave side to be non-responsive.I guess the check alone would be enough but thought increasing the limit was a smoother experience.
Types of Changes
Issues Fixed or Closed by This PR
Checklist