Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German Corne Layout #17268

Merged
merged 33 commits into from
Aug 6, 2022
Merged

German Corne Layout #17268

merged 33 commits into from
Aug 6, 2022

Conversation

JulianTurner
Copy link

@JulianTurner JulianTurner commented May 31, 2022 •
edited
Loading

I added a german Layout with a symbol & navigation layer based on NEOQWERTZ

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes May 31, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the folder to be all lower case.

.vscode/settings.json Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/keycodes.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/keytabs.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/oled.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/JulianTurner/oled.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/colemad/keymap.c Outdated Show resolved Hide resolved
JulianTurner
JulianTurner commented Jun 1, 2022
View reviewed changes
Copy link
Author

@JulianTurner JulianTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved issues

@JulianTurner JulianTurner requested a review from drashna June 1, 2022 09:03
drashna
drashna approved these changes Jun 2, 2022
View reviewed changes
keyboards/crkbd/keymaps/julian_turner/oled.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team June 2, 2022 16:26
fauxpark
fauxpark requested changes Jun 3, 2022
View reviewed changes
keyboards/crkbd/keymaps/julian_turner/rules.mk Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/julian_turner/keycodes.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/julian_turner/keymap.c Outdated Show resolved Hide resolved
JulianTurner
JulianTurner commented Jun 6, 2022
View reviewed changes
Copy link
Author

@JulianTurner JulianTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation of suggestions

@drashna drashna requested a review from a team June 7, 2022 23:09
@JulianTurner
Copy link
Author

Is there anything required on my end?

@noroadsleft noroadsleft merged commit 5c1cfc9 into qmk:master Aug 6, 2022
@noroadsleft
Copy link
Member

noroadsleft commented Aug 6, 2022 •
edited
Loading

Thanks!

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for contributing!

tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Aug 10, 2022
Merge tag '0.17.7'
d8ff6f1 
* tag '0.17.7': (224 commits)
  fix comment space code in quantum/matrix_common.c (qmk#17942)
  Rgbkb/keeb fixes (qmk#17932)
  rgbkb/zen - Resolve CONVERT_TO_PROTON_C warnings (qmk#17619)
  [Keyboard] Dumbpad v1x_oled (qmk#17058)
  [Keyboard] add fave104 (qmk#17909)
  [Keyboard] Add P01 (qmk#17921)
  Lin Works FAve 65H Refactor (qmk#17938)
  RESET -> QK_BOOT default keymaps (qmk#17939)
  [Keymap] German Corne Layout (qmk#17268)
  Update miniZone keymap (qmk#17919)
  Cipulot Kawayo Refactor (qmk#17884)
  Provide users with replacements for deprecated/invalid functionality where applicable (qmk#17604)
  Move keyboard USB IDs and strings to data driven: Z (qmk#17927)
  Move keyboard USB IDs and strings to data driven: Y (qmk#17926)
  Move keyboard USB IDs and strings to data driven: X (qmk#17925)
  [Docs] Building with GitHub Userspace (qmk#16271)
  [Keyboard] Add Crin PCB (qmk#17913)
  Added support for keyquest keyboards (qmk#17667)
  Move keyboard USB IDs and strings to data driven: W (qmk#17903)
  [Keyboard] encoder map on more mechwild boards (qmk#17894)
  ...
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@JulianTurner @imhoffman
[Keymap] German Corne Layout (qmk#17268)
a97f1d2 
* added german corne

* added symbol layer

* Delete settings.json

revert setting

* Delete keymap.c

* Update config.h

* Update keycodes.h

* Update config.h

* Update keyboards/crkbd/keymaps/JulianTurner/oled.c

* Update keycodes.h

* Update oled.c

added header

* Update keymap.c

added header

* Update keytabs.h

added header

* Update readme.md

* Update rules.mk

* default settings

* Update settings.json

* renamed folder

* revert

* remove c file import and added to rules

* Update keymap.c

* Update keymap.c

* Update readme.md

* Update rules.mk

* updated files from pull request

* fixed issues with merge

* Update keyboards/crkbd/keymaps/julian_turner/oled.c

* Update keyboards/crkbd/keymaps/julian_turner/rules.mk

* Update keyboards/crkbd/keymaps/julian_turner/keymap.c

* Delete keycodes.h

* Update keyboards/crkbd/keymaps/julian_turner/readme.md
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@JulianTurner @nolanseaton
[Keymap] German Corne Layout (qmk#17268)
1b6143d 
* added german corne

* added symbol layer

* Delete settings.json

revert setting

* Delete keymap.c

* Update config.h

* Update keycodes.h

* Update config.h

* Update keyboards/crkbd/keymaps/JulianTurner/oled.c

* Update keycodes.h

* Update oled.c

added header

* Update keymap.c

added header

* Update keytabs.h

added header

* Update readme.md

* Update rules.mk

* default settings

* Update settings.json

* renamed folder

* revert

* remove c file import and added to rules

* Update keymap.c

* Update keymap.c

* Update readme.md

* Update rules.mk

* updated files from pull request

* fixed issues with merge

* Update keyboards/crkbd/keymaps/julian_turner/oled.c

* Update keyboards/crkbd/keymaps/julian_turner/rules.mk

* Update keyboards/crkbd/keymaps/julian_turner/keymap.c

* Delete keycodes.h

* Update keyboards/crkbd/keymaps/julian_turner/readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulianTurner @noroadsleft @drashna @fauxpark