updating osx_whiskey_tango_foxtrot_capslock to use process_record_user #16715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanejohnson
force-pushed
the
osx_whiskey_tango_foxtrot_capslock
branch
3 times, most recently
from
dee5b7b
to
4c2522f
Compare
…process_record_user Also updating to actually do bootloader on layer 3
nathanejohnson
force-pushed
the
osx_whiskey_tango_foxtrot_capslock
branch
from
4c2522f
to
b888f44
Compare
drashna
approved these changes
Mar 24, 2022
fauxpark
approved these changes
Mar 24, 2022
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
…process_record_user (qmk#16715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The osx_whiskey_tango_foxtrot_capslock layout for ergodox initially handled faking the caps lock keypress because of macOS's delay on caps key presses. This functionality was previously implemented as an action_get_macro , and since that functionality seems to be deprecated / removed this functionality was lost in the shuffle. This is an attempt to re-implement the same functionality with a process_record_user instead. I have tested this on an original OG ergodox (massdrop kit) and seems to work pretty well.
Types of Changes
Issues Fixed or Closed by This PR
Checklist