Add YDKB Grape PCB #16661
Merged
Add YDKB Grape PCB #16661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keys K2C, K3D, K4E, and K5F weren't working with my attempt at using the driver, but they work with the full custom matrix.
github-actions
bot
added
keyboard
keymap
via
|
From PR checklist,
Matrix implementations which provide their own debounce are generally rejected nowdays. Migrating to "lite" will at least resolve this. |
drashna
requested changes
Mar 15, 2022
drashna
approved these changes
Mar 16, 2022
fauxpark
requested changes
Mar 18, 2022
fauxpark
approved these changes
Mar 25, 2022
6 tasks
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add QMK support for YDKB Grape PCB with default and VIA keymaps.
Attempted to use the SN74x138 demultiplexer driver (#16217) at first, but some keys didn't work. Ended up using the full custom matrix from this TMK fork instead, with the required quantum calls and callback defaults added.Types of Changes
Issues Fixed or Closed by This PR
Checklist