Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yandrstudio/zhou65 #16589

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Fix yandrstudio/zhou65 #16589

merged 2 commits into from
Mar 9, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Mar 8, 2022 •
edited
Loading

Description

RGBLED_NUM is never defined, causing compilation errors when RGBLIGHT is enabled. I've disabled it for the time being until @jiaxin96 can provide the correct number of LEDs to be defined.
Also some misc cleanup.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 8, 2022
zvecr
zvecr requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/yandrstudio/zhou65/rules.mk needs DEFAULT_FOLDER = yandrstudio/zhou65/f401 (or that folder squashed down so it doesnt exist).

@waffle87
Copy link
Member Author

waffle87 commented Mar 8, 2022

keyboards/yandrstudio/zhou65/rules.mk needs DEFAULT_FOLDER = yandrstudio/zhou65/f401 (or that folder squashed down so it doesnt exist).

Gone ahead and removed /f401 directory. Not sure if everything from mcuconf.h is required but..

@fauxpark fauxpark requested a review from a team March 9, 2022 00:04
@zvecr zvecr merged commit 5244b13 into qmk:master Mar 9, 2022
@waffle87 waffle87 deleted the zhou65_fix branch March 9, 2022 00:39
@zvecr zvecr mentioned this pull request Mar 9, 2022
Closed
14 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@waffle87 @zykrah
Fix yandrstudio/zhou65 (qmk#16589)
e7e9682 
* initial cleanup and hotfix for rgb....

* remove /f401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @zvecr