Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Change the default VENDOR_ID to allow VIA support for SICK68 #16563

Merged
merged 1 commit into from
Mar 8, 2022
Merged

[Keyboard] Change the default VENDOR_ID to allow VIA support for SICK68 #16563

merged 1 commit into from
Mar 8, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Mar 7, 2022

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@umbynos umbynos changed the title Change the default VENDOR_ID to allow VIA support [KEYBOARD] Change the default VENDOR_ID to allow VIA support for SICK68 Mar 7, 2022
@umbynos umbynos changed the title [KEYBOARD] Change the default VENDOR_ID to allow VIA support for SICK68 [Keyboard] Change the default VENDOR_ID to allow VIA support for SICK68 Mar 7, 2022
@umbynos
Copy link
Contributor Author

umbynos commented Mar 7, 2022

#16509

@drashna drashna requested a review from a team March 8, 2022 02:12
@drashna drashna merged commit f0d27e2 into qmk:master Mar 8, 2022
@umbynos umbynos deleted the patch-1 branch March 8, 2022 09:23
@xia0 xia0 mentioned this pull request Mar 8, 2022
Merged
6 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@umbynos @zykrah
[Keyboard] Change vendor ID for sick68 keyboard (qmk#16563)
04fa21a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @drashna @fauxpark