Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] Personal keymap for crkbd #16546

Merged
merged 6 commits into from
Mar 9, 2022
Merged

[Keymap] Personal keymap for crkbd #16546

merged 6 commits into from
Mar 9, 2022

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Mar 6, 2022 •
edited
Loading

Personal keymap for crkbd

Description

  • Renders on slave an animation of a cat which speed varies based on WPM (similar to Bongo Cat but simpler)
  • Implement "a SArCasM moDE"

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Mar 6, 2022
drashna
drashna requested changes Mar 7, 2022
View reviewed changes
keyboards/crkbd/keymaps/jpe230/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/config.h Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 8, 2022 01:58
fauxpark
fauxpark requested changes Mar 8, 2022
View reviewed changes
keyboards/crkbd/keymaps/jpe230/README.md Outdated Show resolved Hide resolved
drashna
drashna requested changes Mar 8, 2022
View reviewed changes
keyboards/crkbd/keymaps/jpe230/keymap.c Outdated Show resolved Hide resolved
@drashna drashna merged commit 6ab5a7d into qmk:master Mar 9, 2022
@Jpe230 Jpe230 deleted the jpe230_corne branch March 9, 2022 14:52
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Jpe230 @zykrah
[Keymap] Personal keymap for crkbd (qmk#16546)
8dd4a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jpe230 @drashna @fauxpark