Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More validation of declared LAYOUT macro names #16520

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 4, 2022

Description

Validation of keymap.json has shown that many more layout macros are considered invalid. info.json can currently contain values that cannot be keyed against with the corresponding keymap.json property.

Adding in the validation from #16142 along with a ton of exceptions will keep the 2 logical parts in step.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 4, 2022
@zvecr zvecr requested a review from a team March 4, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot compile preonic/rev3_drop on LAYOUT_preonic_1x2uC
2 participants