Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: 1upkeyboards super16v2 #16198

Merged
merged 9 commits into from
Feb 9, 2022
Merged

New Keyboard: 1upkeyboards super16v2 #16198

merged 9 commits into from
Feb 9, 2022

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Feb 4, 2022 •
edited
Loading

Description

Add a new 1upkeyboards keyboard the super16v2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added keyboard via Adds via keymap and/or updates keyboard for via support labels Feb 4, 2022
@github-actions github-actions bot added the keymap label Feb 4, 2022
drashna
drashna requested changes Feb 4, 2022
View reviewed changes
keyboards/1upkeyboards/super16v2/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team February 9, 2022 05:22
@drashna drashna merged commit c212b65 into qmk:master Feb 9, 2022
@mechmerlin mechmerlin mentioned this pull request Feb 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mechmerlin @drashna @fauxpark